You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/21 03:40:09 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #782: Add EVAL_RO

git-hulk commented on code in PR #782:
URL: https://github.com/apache/incubator-kvrocks/pull/782#discussion_r976004115


##########
tests/gocase/unit/command/command_test.go:
##########
@@ -35,13 +35,6 @@ func TestCommand(t *testing.T) {
 	rdb := srv.NewClient()
 	defer func() { require.NoError(t, rdb.Close()) }()
 
-	t.Run("Kvrocks supports 183 commands currently", func(t *testing.T) {
-		r := rdb.Do(ctx, "COMMAND", "COUNT")
-		v, err := r.Int()
-		require.NoError(t, err)
-		require.Equal(t, 183, v)
-	})
-

Review Comment:
   Yes, as said in comment: https://github.com/apache/incubator-kvrocks/pull/782#issuecomment-1252227937, this test case is not much help for us and it causes conflicts frequently, so I think we should remove.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org