You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aIbrahiim (via GitHub)" <gi...@apache.org> on 2026/07/22 15:38:39 UTC
[PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
aIbrahiim opened a new pull request, #39436:
URL: https://github.com/apache/beam/pull/39436
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #39436:
URL: https://github.com/apache/beam/pull/39436#issuecomment-5059273074
This change made some version specific logic which adds maintenance burden in the future. I see currently the workflow is green and work fine
========
I may have missed something, but currently the workflow already runs each python version in different matrix:
https://github.com/apache/beam/actions/runs/29992852197
as one can see, Python 3.14 and 3.14 distroless have they own job:
https://github.com/apache/beam/actions/runs/29992852197/job/89159380239
https://github.com/apache/beam/actions/runs/29992852197/job/89159380379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim closed pull request #39436: Isolate Python 3.14 SDK snapshot publishes from the main matrix
URL: https://github.com/apache/beam/pull/39436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39436:
URL: https://github.com/apache/beam/pull/39436#issuecomment-5048476580
Assigning reviewers:
R: @Abacn for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #39436:
URL: https://github.com/apache/beam/pull/39436#discussion_r3631632227
##########
.github/workflows/beam_Publish_Beam_SDK_Snapshots.yml:
##########
@@ -127,3 +125,67 @@
-Pcontainer-architecture-list=arm64,amd64 \
-Ppush-containers \
-Pdocker-pull-licenses
+
+ beam_Publish_Beam_SDK_Snapshots_py314:
+ needs: beam_Publish_Beam_SDK_Snapshots
+ if: |
+ always() &&
+ !cancelled() &&
+ (github.event_name == 'workflow_dispatch' ||
+ (github.event_name == 'schedule' && github.repository == 'apache/beam'))
+ runs-on: [self-hosted, ubuntu-24.04, main]
+ timeout-minutes: 300
+ name: ${{ matrix.job_name }} (${{ matrix.container_task }})
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: ["beam_Publish_Beam_SDK_Snapshots"]
+ job_phrase: ["N/A"]
+ container_task:
+ - "python:container:py314:docker"
+ - "python:container:distroless:py314:docker"
+ steps:
+ - uses: actions/checkout@v7
+ with:
+ persist-credentials: false
+ - name: Free Disk Space (Ubuntu)
+ uses: jlumbroso/free-disk-space@v1.3.1
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.container_task }})
+ - name: Find Beam Version
+ run: |
+ BEAM_VERSION_LINE=$(cat gradle.properties | grep "sdk_version")
+ echo "BEAM_VERSION=${BEAM_VERSION_LINE#*sdk_version=}" >> $GITHUB_ENV
Review Comment:
## CodeQL / Environment variable built from user-controlled sources
Potential environment variable injection in [BEAM_VERSION_LINE=$(cat gradle.properties | grep "sdk_version")
echo "BEAM_VERSION=${BEAM_VERSION_LINE#*sdk_version=}" >> $GITHUB_ENV](1), which may be controlled by an external user ([workflow_dispatch](2)).
Potential environment variable injection in [BEAM_VERSION_LINE=$(cat gradle.properties | grep "sdk_version")
echo "BEAM_VERSION=${BEAM_VERSION_LINE#*sdk_version=}" >> $GITHUB_ENV](1), which may be controlled by an external user ([workflow_dispatch](2)).
[Show more details](https://github.com/apache/beam/security/code-scanning/1897)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39436:
URL: https://github.com/apache/beam/pull/39436#issuecomment-5059973611
@Abacn
regarding py314 has its own matrix jobs, those jobs still start at the same timeas the others and share the same runners
and on the current pr I just tried to change the timing as main matrix runs without py314 first, then py314 / distroless:py314 run after (needs:) and it just tries to reduce runner contention
so yes the version-specific split adds maintenance if snapshots is already fine, maybe this isn't worth it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "aIbrahiim (via GitHub)" <gi...@apache.org>.
aIbrahiim commented on PR #39436:
URL: https://github.com/apache/beam/pull/39436#issuecomment-5059894432
> This change made some version specific logic which adds maintenance burden in the future. I see currently the workflow is green and work fine
>
> ========
>
> I may have missed something, but currently the workflow already runs each python version in different matrix:
>
> https://github.com/apache/beam/actions/runs/29992852197
>
> as one can see, Python 3.14 and 3.14 distroless have they own job:
>
> https://github.com/apache/beam/actions/runs/29992852197/job/89159380239
>
> https://github.com/apache/beam/actions/runs/29992852197/job/89159380379
>
> ========
>
> If the concern is on postcommit tests, we can make Python ARM PostCommits to use prebuild containers (gcr.io/apache-beam-testing/beam_python*_sdk:latest) to save time.
Thank you for the feedback @Abacn
okay right each Python version already has its own matrix job, I may have overstated that part and in this PR I was trying to only change when py314 runs so today everything starts together and shares the same runners, and this would make py314 wait until the main matrix finishes
But I got it as this adds version-specific logic and extra maintenance, and if Snapshots is already green, the benefit is pretty small
I will also consider reusing the prebuilt images and check in a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Isolate Python 3.14 SDK snapshot publishes from the main matrix [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #39436:
URL: https://github.com/apache/beam/pull/39436#issuecomment-5048209055
> [!CAUTION]
> The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org