[GitHub] [solr] cpoerschke commented on a diff in pull request #930: SOLR-16281: review boxing unboxing

[GitBox <gi...@apache.org>]

cpoerschke commented on code in PR #930:
URL: https://github.com/apache/solr/pull/930#discussion_r913162412


##########
solr/core/src/test/org/apache/solr/handler/component/TestPivotHelperCode.java:
##########
@@ -89,8 +89,7 @@ public void testCompareWithNullLast() {
     assertEquals(a.compareTo(b), PivotFacetFieldValueCollection.compareWithNullLast(a, b));
     assertEquals(b.compareTo(a), PivotFacetFieldValueCollection.compareWithNullLast(b, a));
 
-    Long bb = new Long(b.longValue());
-    assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, bb));
+    assertEquals(0, PivotFacetFieldValueCollection.compareWithNullLast(b, b));

Review Comment:
   hmm, not sure about this one, looks like it's part of the test?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org