You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Jaydeep Vishwakarma (JIRA)" <ji...@apache.org> on 2015/02/19 10:52:11 UTC
[jira] [Commented] (OOZIE-1918) ActionXCommand refactoring for code
reuse
[ https://issues.apache.org/jira/browse/OOZIE-1918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327173#comment-14327173 ]
Jaydeep Vishwakarma commented on OOZIE-1918:
--------------------------------------------
These classes have so many changes from when you uploaded the patch. Can you please rebase your code and upload the patch again , I would like to review the patch.
> ActionXCommand refactoring for code reuse
> -----------------------------------------
>
> Key: OOZIE-1918
> URL: https://issues.apache.org/jira/browse/OOZIE-1918
> Project: Oozie
> Issue Type: Improvement
> Components: action
> Affects Versions: trunk
> Reporter: Azrael
> Assignee: Azrael
> Priority: Trivial
> Attachments: OOZIE-1918.1.patch, OOZIE-1918.2.patch
>
>
> Subclasses of ActionXCommand have some duplicated code. Refactoring make it more neat.
> This patch contain:
> * Renaming CompletedActionXCommand to ActionCompletedXCommand and extending ActionXCommand
> * Moving some variables and methods to ActionXCommand and making it protected
> * More meaningful log message : actionId is duplicated so removed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)