[jira] [Comment Edited] (OPENJPA-2410) Build time detection of System.out/err.print(ln) in source files

["Di Wu Lau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713008#comment-13713008 ] 

Di Wu Lau edited comment on OPENJPA-2410 at 7/18/13 10:38 PM:
--------------------------------------------------------------

Hi Rick, I think you meant " // STOP - ALLOW PRINT STATEMENTS " instead of " // END - ALLOW PRINT STATEMENTS " in the checkstyle.xml? It is still "END" for right now. In the java files, it is "STOP". This could cause build failure as we set severity=error for the print statements.
                
      was (Author: dlau):
    Hi Rick, I think you meant " // STOP - ALLOW PRINT STATEMENTS " instead of " // END - ALLOW PRINT STATEMENTS " in the checkstyle.xml? It is still "END" for right now. It could cause build failure as we set severity=error for the print statements.
                  
> Build time detection of System.out/err.print(ln) in source files
> ----------------------------------------------------------------
>
>                 Key: OPENJPA-2410
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2410
>             Project: OpenJPA
>          Issue Type: Improvement
>          Components: build / infrastructure
>    Affects Versions: 2.3.0
>            Reporter: Di Wu Lau
>            Assignee: Rick Curtis
>            Priority: Minor
>             Fix For: 2.3.0
>
>         Attachments: OPENJPA-2410.patch
>
>
> Source files may have inadvertent System.out/err.print statements left in source files on commit. Ideally we don't want any of these changes being checked in and a large majority of the time logging facilities should be utilized. That being said, there are a number of cases where we don't have access to a logger and must use System.out/err.
> This JIRA will be used to update our checkstyle to scan for unwanted print statements, and fail the build when/if they are encountered.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira