You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/08/31 13:24:31 UTC
[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments
fgerlits commented on a change in pull request #884:
URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r480120751
##########
File path: extensions/http-curl/tests/HTTPHandlers.h
##########
@@ -428,7 +428,7 @@ class HeartbeatHandler : public ServerAwareHandler {
void verify(struct mg_connection *conn) {
auto post_data = readPayload(conn);
- //std::cerr << post_data << std::endl;
+ // std::cerr << post_data << std::endl;
Review comment:
should be deleted
##########
File path: extensions/http-curl/tests/CivetStream.h
##########
@@ -119,7 +119,7 @@ class CivetStream : public io::BaseStream {
return readData(reinterpret_cast<uint8_t *>(&buf[0]), sizeof(t));
}
- //size_t pos;
+ // size_t pos;
Review comment:
some of these should probably be deleted rather than fixing the whitespace in them; this is an example of that
##########
File path: main/MiNiFiWindowsService.cpp
##########
@@ -27,7 +27,7 @@
#include "MainHelper.h"
#include "core/FlowConfiguration.h"
-//#define DEBUG_SERVICE
+// #define DEBUG_SERVICE
Review comment:
should be deleted
##########
File path: nanofi/include/sitetosite/CSiteToSite.h
##########
@@ -267,7 +267,7 @@ typedef struct {
// Whether received data is available
int _dataAvailable;
- //org::apache::nifi::minifi::io::BaseStream* _stream;
+ // org::apache::nifi::minifi::io::BaseStream* _stream;
Review comment:
should be deleted
##########
File path: nanofi/src/sitetosite/CRawSocketProtocol.c
##########
@@ -72,10 +72,10 @@ typedef struct {
int handShake(struct CRawSiteToSiteClient * client) {
if (client->_peer_state != ESTABLISHED) {
- //client->logger_->log_error("Site2Site peer state is not established while handshake");
+ // client->logger_->log_error("Site2Site peer state is not established while handshake");
return -1;
}
- //client->logger_->log_debug("Site2Site Protocol Perform hand shake with destination port %s", client->_port_id_str);
+ // client->logger_->log_debug("Site2Site Protocol Perform hand shake with destination port %s", client->_port_id_str);
Review comment:
should be deleted
##########
File path: nanofi/src/sitetosite/CRawSocketProtocol.c
##########
@@ -153,7 +153,7 @@ int handShake(struct CRawSiteToSiteClient * client) {
if (client->_currentVersion >= 3) {
- //ret = client->_peer->writeUTF(client->_peer->getURL());
+ // ret = client->_peer->writeUTF(client->_peer->getURL());
Review comment:
should be deleted
##########
File path: extensions/jni/jvm/JniProcessContext.h
##########
@@ -69,8 +69,8 @@ DLL_EXPORT jstring JNICALL Java_org_apache_nifi_processor_JniProcessContext_getN
DLL_EXPORT jobject JNICALL Java_org_apache_nifi_processor_JniProcessContext_getControllerServiceLookup(JNIEnv *env, jobject obj);
-//getname
-//getControllerservicelookup
+// getname
+// getControllerservicelookup
Review comment:
should be deleted
##########
File path: extensions/libarchive/FocusArchiveEntry.cpp
##########
@@ -130,7 +130,7 @@ void FocusArchiveEntry::onTrigger(core::ProcessContext *context, core::ProcessSe
}
archiveStack.push(archiveMetadata);
- //logger_->log_debug(archiveMetadata.toJsonString());
+ // logger_->log_debug(archiveMetadata.toJsonString());
Review comment:
should be deleted
##########
File path: nanofi/src/api/nanofi.cpp
##########
@@ -544,7 +544,7 @@ processor *add_python_processor(flow *flow, processor_logic* logic) {
return nullptr;
}
auto lambda = [logic](core::ProcessSession *ps, core::ProcessContext *cx) {
- logic(static_cast<processor_session*>(ps), static_cast<processor_context*>(cx)); //Meh, sorry for this
+ logic(static_cast<processor_session*>(ps), static_cast<processor_context*>(cx)); // Meh, sorry for this
Review comment:
Does http://whatthecommit.com take user submissions? This comment would be a good candidate for that. :)
##########
File path: nanofi/include/sitetosite/CSiteToSite.h
##########
@@ -332,7 +332,7 @@ static int writeData(CTransaction * transaction, const uint8_t *value, int size)
}
static int readData(CTransaction * transaction, uint8_t *buf, int buflen) {
- //int ret = transaction->_stream->read(buf, buflen);
+ // int ret = transaction->_stream->read(buf, buflen);
Review comment:
should be deleted
##########
File path: extensions/sftp/tests/FetchSFTPTests.cpp
##########
@@ -142,7 +142,7 @@ class FetchSFTPTestsFixture {
std::fstream file;
std::stringstream ss;
ss << src_dir << "/vfs/" << relative_path;
- utils::file::FileUtils::create_dir(utils::file::FileUtils::get_parent_path(ss.str())); // TODO
+ utils::file::FileUtils::create_dir(utils::file::FileUtils::get_parent_path(ss.str())); // TODO
Review comment:
the comment should be deleted
##########
File path: nanofi/src/core/cstream.c
##########
@@ -149,7 +149,7 @@ int readUTFLen(uint32_t * utflen, cstream * stream) {
}
int readUTF(char * buf, uint32_t buflen, cstream * stream) {
- //return stream->impl->readData((uint8_t*)buf, buflen);
+ // return stream->impl->readData((uint8_t*)buf, buflen);
Review comment:
should be deleted
##########
File path: nanofi/src/sitetosite/CRawSocketProtocol.c
##########
@@ -72,10 +72,10 @@ typedef struct {
int handShake(struct CRawSiteToSiteClient * client) {
if (client->_peer_state != ESTABLISHED) {
- //client->logger_->log_error("Site2Site peer state is not established while handshake");
+ // client->logger_->log_error("Site2Site peer state is not established while handshake");
Review comment:
should be deleted
##########
File path: extensions/windows-event-log/TailEventLog.cpp
##########
@@ -115,7 +115,7 @@ void TailEventLog::onTrigger(const std::shared_ptr<core::ProcessContext> &contex
flowFile->addAttribute("event_time", getTimeStamp(event_record->TimeGenerated));
flowFile->addAttribute("event_type", typeToString(event_record->EventType));
- //flowFile->addAttribute("", event_message);
+ // flowFile->addAttribute("", event_message);
Review comment:
should be deleted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org