You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/01 04:29:50 UTC

[GitHub] [iceberg] rdblue commented on a change in pull request #1539: Add names to parameterized tests and simplify the parameters list

rdblue commented on a change in pull request #1539:
URL: https://github.com/apache/iceberg/pull/1539#discussion_r497977246



##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -130,6 +130,24 @@ public void close() throws CatalogException {
     }
   }
 
+  // Going to save this change for another PR as this PR is already really big.

Review comment:
       Can we remove these lines then?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org