You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yuluo-yx (via GitHub)" <gi...@apache.org> on 2026/08/28 16:51:31 UTC
[I] [Studio][Bug] Trim broker flush-disk configuration values [rocketmq-dashboard]
yuluo-yx opened a new issue, #2700:
URL: https://github.com/apache/rocketmq-dashboard/issues/2700
## Problem
Broker configuration parsing trims integer values but passes `flushDiskType` to the enum parser unchanged. A valid broker value such as `" SYNC_FLUSH "` is therefore treated as unknown and silently reported as `ASYNC_FLUSH`.
## Reproduction
Return broker properties containing `flushDiskType = " SYNC_FLUSH "` from the admin API. The mapped Studio configuration reports `ASYNC_FLUSH`.
## Expected behavior
Ignore surrounding whitespace for valid flush-disk values while preserving the existing fallback for genuinely unknown values.
## Scope
Normalize the value at the parser boundary and add a focused service test for padded valid and unknown values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Trim broker flush-disk configuration values [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on issue #2700:
URL: https://github.com/apache/rocketmq-dashboard/issues/2700#issuecomment-5455440271
**Issue Evaluation**
Category: `bug` | Status: **Confirmed**
Broker configuration parsing trims integer values but passes `flushDiskType` to the enum parser without trimming whitespace. A valid value like ` SYNC_FLUSH ` (with surrounding spaces) is treated as unknown and silently mapped to `ASYNC_FLUSH`, giving incorrect configuration feedback.
**Root Cause:** Inconsistent whitespace handling — integer fields are trimmed but enum fields are not.
**Impact:** Broker configuration UI; silent misconfiguration of flush disk type.
**Severity:** Medium — silent data corruption in configuration display, could lead to incorrect operational decisions.
The proposed scope (normalize at parser boundary + focused service test) is well-targeted.
An automated fix proposal can be generated. Reply `/approve` to proceed with PR generation.
---
*Automated evaluation by RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Trim broker flush-disk configuration values [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on issue #2700:
URL: https://github.com/apache/rocketmq-dashboard/issues/2700#issuecomment-5506315775
Resolved by #2849 (merged into rocketmq-studio as 33fe90ff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Studio][Bug] Trim broker flush-disk configuration values [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed issue #2700: [Studio][Bug] Trim broker flush-disk configuration values
URL: https://github.com/apache/rocketmq-dashboard/issues/2700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org