You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/18 18:58:55 UTC

[GitHub] [arrow] nevi-me commented on pull request #8856: ARROW-10940: [Rust] Extend sort kernel to ListArray

nevi-me commented on pull request #8856:
URL: https://github.com/apache/arrow/pull/8856#issuecomment-748262641


   Hi @waynexia, thank you for taking this on, and I apologise for the delay, I haven't had enough time to review PRs.
   
   I suggest that we keep the `list_sort` in the sort kernel for now. We already have other ListArray-specific kernels like `ListArray::contains(PrimitiveArray)` in the other kernel modules, so we can keep to that practise for now. @jorgecarleitao do you concur?
   
   We can later move all ListArray-specific functions to a separate module.
   
   I'll review this over the weekend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org