[GitHub] aaronbannin edited a comment on issue #5325: ImpalaEngineSpec inherits HiveEngineSpec

[GitBox <gi...@apache.org>]

aaronbannin edited a comment on issue #5325: ImpalaEngineSpec inherits HiveEngineSpec
URL: https://github.com/apache/incubator-superset/pull/5325#issuecomment-402565265
 
 
   I haven't manually tested every method that is inherited in the Hive and Presto classes, but slices seem to be working just fine for Impala. The partition and logging functionality seem to work just fine (hard for me to be certain w/o automated tests). The only issue I've seen is the TCLI compatibility in SQL Lab (which feels like it's a dependency collision). 
   
   My primary goal was to get `epoch_s` to work for Impala, perhaps I should submit a new PR with that change and figure out how to test this further?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org