You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/15 08:29:59 UTC

[GitHub] [hadoop-ozone] maobaolong opened a new pull request #825: HDDS-3395. Move the protobuf convert code to the OMHelper

maobaolong opened a new pull request #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825
 
 
   ## What changes were proposed in this pull request?
   
   Clear the source file above the proto layer. 
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3395
   
   ## How was this patch tested?
   
   Passed the ci tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 edited a comment on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper

Posted by GitBox <gi...@apache.org>.
bharatviswa504 edited a comment on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-614930795
 
 
   I believe instead of moving proto conversions into OMPBHelper, I believe the current approach of each Class having the logic of conversion to/from protobuf looks cleaner. With the PR approach, there will be one big huge class that does all this conversion. I feel the current way looks easy, wherein a single place has an entire code for it.
   
   Thoughts?? If there is any strong reason in doing this way, I am happy to hear the reasons.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] maobaolong commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper

Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-614010521
 
 
   @elek Please take a look, thank you.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper

Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-614930795
 
 
   I believe instead of moving this in to OMPBHelper, I believe current approach of Each Class having the logic of conversion to/from protobuf looks cleaner. With the PR approach, there will be one big huge class that does all this conversion. I feel the current way looks easy, wherein a single place has an entire code for it.
   
   Thoughts?? If there is any strong reason in doing this way, I am happy to hear the reasons.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] maobaolong commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper

Posted by GitBox <gi...@apache.org>.
maobaolong commented on issue #825: HDDS-3395. Move the protobuf convert code to the OMHelper
URL: https://github.com/apache/hadoop-ozone/pull/825#issuecomment-615009528
 
 
   @bharatviswa504 Thank you for your review and your reply. There are the reasons why i did this moving.
   
   - If I don't build my repo locally, it means that the local source repo lack of the java source files generated by protobuf, for the current approach, many error appear in the classes contains reference of protobuf generated class while you view source in an IDE, whatever intellij idea and Eclipse. 
   - Put the serialized and deserialized logic into the high level class, i think it is harmful for reading high level code logic, actually, some people do not care about how to serialized but care more about the data structure. Now each class have two method for serialized and deserialized purpose, and it is red color by IDE before i successful compile my repo.
   - I think we can separate the class into two layer, and the serialized and deserialized logic should be in the low-level layer.
   - In fact, i'm effected by HDFS and Alluxio, so, i'm very happy to discuss with you further more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org