You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/17 12:47:43 UTC

[GitHub] [druid] petermarshallio commented on a change in pull request #11926: Docs - Corrected admonition issue

petermarshallio commented on a change in pull request #11926:
URL: https://github.com/apache/druid/pull/11926#discussion_r751206903



##########
File path: docs/ingestion/data-formats.md
##########
@@ -598,8 +598,10 @@ For example:
   ]
 }
 ```
-After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
-> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec). Keep this in mind when writing your ingestion spec.
+> After Druid reads the input data records, it applies the flattenSpec before applying any other specs such as
+> [`timestampSpec`](./ingestion-spec.md#timestampspec), [`transformSpec`](./ingestion-spec.md#transformspec),
+> [`dimensionsSpec`](./ingestion-spec.md#dimensionsspec), or [`metricsSpec`](./ingestion-spec.md#metricsspec).
+> Keep this in mind when writing your ingestion spec.

Review comment:
       Ha!  I think @techdocsmith would definitely agree with you on the admonition part haha. I wonder maybe if it was an MD edit error when one of the > were left in and it should have been taken out.  I think it's important people know the order that this is applied in, though, so the content is probably useful to keep in.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org