You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@commons.apache.org by gg...@apache.org on 2017/12/05 20:47:57 UTC

svn commit: r1817232 - /commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java

Author: ggregory
Date: Tue Dec  5 20:47:56 2017
New Revision: 1817232

URL: http://svn.apache.org/viewvc?rev=1817232&view=rev
Log:
Fix bug in test to avoid an exception if a key does not exist.

Modified:
    commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java

Modified: commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java?rev=1817232&r1=1817231&r2=1817232&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java (original)
+++ commons/proper/bcel/trunk/src/test/java/org/apache/bcel/generic/JDKGenericDumpTestCase.java Tue Dec  5 20:47:56 2017
@@ -62,7 +62,9 @@ public class JDKGenericDumpTestCase {
     private static final String KEY_JRE_9 = "SOFTWARE\\JavaSoft\\JRE";
 
     private static void addAllJavaHomesOnWindows(final String keyJre, final Set<String> javaHomes) {
-        javaHomes.addAll(findJavaHomesOnWindows(keyJre, Advapi32Util.registryGetKeys(HKEY_LOCAL_MACHINE, keyJre)));
+        if (Advapi32Util.registryKeyExists(HKEY_LOCAL_MACHINE, keyJre)) {
+            javaHomes.addAll(findJavaHomesOnWindows(keyJre, Advapi32Util.registryGetKeys(HKEY_LOCAL_MACHINE, keyJre)));
+        }
     }
 
     private static String bytesToHex(final byte[] bytes) {