[GitHub] [maven] michael-o commented on a diff in pull request #828: Fix site generation

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #828:
URL: https://github.com/apache/maven/pull/828#discussion_r995582438


##########
maven-model-builder/src/main/java/org/apache/maven/model/inheritance/DefaultInheritanceAssembler.java:
##########
@@ -337,7 +337,7 @@ protected void mergeReporting_Plugins( Reporting.Builder builder,
                     if ( element.isInherited() )
                     {
                         // NOTE: Enforce recursive merge to trigger merging/inheritance logic for executions as well
-                        ReportPlugin plugin = ReportPlugin.newInstance();
+                        ReportPlugin plugin = ReportPlugin.newInstance( false );

Review Comment:
   Why does this make a difference?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org