svn commit: r370795 - /incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/

[ju...@apache.org]

Author: jukka
Date: Fri Jan 20 03:51:49 2006
New Revision: 370795

URL: http://svn.apache.org/viewcvs?rev=370795&view=rev
Log:
JCR-306: Reverted finalization of the Config classes. There appear to be valid use cases for subclassing the configuration.

Modified:
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/AccessManagerConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/FileSystemConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/LoginModuleConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/PersistenceManagerConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/RepositoryConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/SearchConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/VersioningConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/WorkspaceConfig.java
    incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/package.html

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/AccessManagerConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/AccessManagerConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/AccessManagerConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/AccessManagerConfig.java Fri Jan 20 03:51:49 2006
@@ -25,7 +25,7 @@
  *
  * @see RepositoryConfig#getAccessManagerConfig()
  */
-public final class AccessManagerConfig extends BeanConfig {
+public class AccessManagerConfig extends BeanConfig {
 
     /**
      * Creates an access manager configuration object from the

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/FileSystemConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/FileSystemConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/FileSystemConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/FileSystemConfig.java Fri Jan 20 03:51:49 2006
@@ -28,7 +28,7 @@
  * previously created by the {@link #init() init()} method.
  *
  */
-public final class FileSystemConfig extends BeanConfig {
+public class FileSystemConfig extends BeanConfig {
 
     /** The initialized file system implementation. */
     private FileSystem fs;

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/LoginModuleConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/LoginModuleConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/LoginModuleConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/LoginModuleConfig.java Fri Jan 20 03:51:49 2006
@@ -28,7 +28,7 @@
  * @see RepositoryConfig#getLoginModuleConfig()
  * @version $Id$
  */
-public final class LoginModuleConfig extends BeanConfig {
+public class LoginModuleConfig extends BeanConfig {
 
     /**
      * Creates an access manager configuration object from the

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/PersistenceManagerConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/PersistenceManagerConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/PersistenceManagerConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/PersistenceManagerConfig.java Fri Jan 20 03:51:49 2006
@@ -25,7 +25,7 @@
  *
  * @see WorkspaceConfig#getPersistenceManagerConfig()
  */
-public final class PersistenceManagerConfig extends BeanConfig {
+public class PersistenceManagerConfig extends BeanConfig {
 
     /**
      * Creates a persistence manager configuration object from the

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/RepositoryConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/RepositoryConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/RepositoryConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/RepositoryConfig.java Fri Jan 20 03:51:49 2006
@@ -57,7 +57,7 @@
  * addition the workspace configuration object keeps track of all configured
  * workspaces.
  */
-public final class RepositoryConfig {
+public class RepositoryConfig {
 
     /** Name of the workspace configuration file. */
     private static final String WORKSPACE_XML = "workspace.xml";

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/SearchConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/SearchConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/SearchConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/SearchConfig.java Fri Jan 20 03:51:49 2006
@@ -30,7 +30,7 @@
  *
  * @see WorkspaceConfig#getSearchConfig()
  */
-public final class SearchConfig extends BeanConfig {
+public class SearchConfig extends BeanConfig {
 
     /**
      * The search index file system configuration, or <code>null</code> if

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/VersioningConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/VersioningConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/VersioningConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/VersioningConfig.java Fri Jan 20 03:51:49 2006
@@ -30,7 +30,7 @@
  *
  * @see RepositoryConfig#getVersioningConfig()
  */
-public final class VersioningConfig {
+public class VersioningConfig {
 
     /**
      * Versioning home directory.

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/WorkspaceConfig.java
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/WorkspaceConfig.java?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/WorkspaceConfig.java (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/WorkspaceConfig.java Fri Jan 20 03:51:49 2006
@@ -25,7 +25,7 @@
  * search index configuration. The search index is an optional part of the
  * configuration.
  */
-public final class WorkspaceConfig {
+public class WorkspaceConfig {
 
     /**
      * Workspace home directory.

Modified: incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/package.html
URL: http://svn.apache.org/viewcvs/incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/package.html?rev=370795&r1=370794&r2=370795&view=diff
==============================================================================
--- incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/package.html (original)
+++ incubator/jackrabbit/trunk/jackrabbit/src/main/java/org/apache/jackrabbit/core/config/package.html Fri Jan 20 03:51:49 2006
@@ -45,11 +45,13 @@
 
 <h2>Modifying configuration</h2>
 <p>
-The configuration classes in this package are immutable and <code>final</code>
-to enforce the contract that the configuration should not be modified once
-it has been intstantiated. The public constructors allow a limited form of
-dynamic configurability for Jackrabbit, but note that the only officially
-supported Jackrabbit configuration interface are the XML configuration files.
+The configuration classes in this package are immutable to enforce the
+contract that the configuration should not be modified once it has been
+intstantiated. It is possible to subclass the configuration classes as long
+as the immutability contract is not broken. The public constructors allow
+a limited form of dynamic configurability for Jackrabbit, but note that the
+only officially supported Jackrabbit configuration interface are the XML
+configuration files.
 </p>
 
 </body>