You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 10:07:47 UTC
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #5483: marvin: Fix intermittent failure observed in test_02_list_snapshots_with_removed_data_store
Pearl1594 commented on a change in pull request #5483:
URL: https://github.com/apache/cloudstack/pull/5483#discussion_r712893095
##########
File path: test/integration/smoke/test_snapshots.py
##########
@@ -302,14 +302,23 @@ def test_02_list_snapshots_with_removed_data_store(self):
self.apiclient,
vol
)
- self.virtual_machine_with_disk.detach_volume(
+ detach_vol_res = self.virtual_machine_with_disk.detach_volume(
self.apiclient,
vol
)
+ if detach_vol_res.storageid != storage.id:
+ dest_store = storage
+ else:
+ all_stores = store_pools = list_storage_pools(self.apiclient)
+ for store in all_stores:
+ if store.id != storage.id:
+ dest_store = store
Review comment:
Thanks @sureshanaparti - you are right, I've refactored it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org