[GitHub] [ignite-3] korlov42 commented on a diff in pull request #1456: IGNITE-18206 Sql. Prohibit using 2-phase aggregates with distinct accumulator on map phase

[GitBox <gi...@apache.org>]

korlov42 commented on code in PR #1456:
URL: https://github.com/apache/ignite-3/pull/1456#discussion_r1055176183


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/rule/HashAggregateConverterRule.java:
##########
@@ -74,6 +77,21 @@ protected PhysicalNode convert(RelOptPlanner planner, RelMetadataQuery mq,
         }
     }
 
+    /**
+     * Return {@code true} if observes COUNT and DISTINCT simultaneously in aggregate.
+     *
+     * @param aggCalls Aggregates.
+     * @return {@code true} If found, {@code false} otherwise.
+     */
+    private static boolean countWithDistinctAgg(List<AggregateCall> aggCalls) {

Review Comment:
   what about other aggregate functions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org