You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/10 10:04:46 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

jorisvandenbossche commented on a change in pull request #8878:
URL: https://github.com/apache/arrow/pull/8878#discussion_r540035388



##########
File path: python/pyproject.toml
##########
@@ -18,8 +18,8 @@
 [build-system]
 requires = [
     "cython >= 0.29",
-    "numpy==1.14.5; python_version<'3.7'",
-    "numpy==1.16.0; python_version>='3.7'",
+    "numpy==1.16.6; python_version<='3.8'",

Review comment:
       ```suggestion
       "numpy==1.16.6; python_version<'3.9'",
   ```
   I don't know how exactly those versions are matched (eg is 3.8.5 <= 3.8 ?), so this might be clearer
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org