You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/21 18:19:06 UTC
[GitHub] [superset] codemaster08240328 opened a new pull request #18837: FIX: Add case sensitive option to SelectControl #17716
codemaster08240328 opened a new pull request #18837:
URL: https://github.com/apache/superset/pull/18837
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The d3 time format selection widgets use case insensitive match in filter option, which prevents users from inputing formats which match in a case insensitive manner.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
> After Update
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
1. Go to `explore`
2. Create a new `Time-series Line Chart`
3. Click on the `CUSTOMIZE` tab.
4. Try entering the `%b %Y` d3 format for the X-Axis time format.
5. See that the UI component uses case-sensitive in filtering options.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18837: fix: Add case sensitive option to SelectControl
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18837:
URL: https://github.com/apache/superset/pull/18837#issuecomment-1062240633
Closing in favor of https://github.com/apache/superset/pull/18856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #18837: fix: Add case sensitive option to SelectControl
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #18837:
URL: https://github.com/apache/superset/pull/18837#issuecomment-1048304748
Conflict with #18856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed pull request #18837: fix: Add case sensitive option to SelectControl
Posted by GitBox <gi...@apache.org>.
rusackas closed pull request #18837:
URL: https://github.com/apache/superset/pull/18837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #18837: fix: Add case sensitive option to SelectControl
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #18837:
URL: https://github.com/apache/superset/pull/18837#issuecomment-1058356071
I believe @michael-s-molina and @geido are coming through to look at all of these SelectControl PRs that are open. Hopefully as code owners they'll be able to make a decision of how to proceed with this one given Jesse's conflict warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #18837: fix: Add case sensitive option to SelectControl
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #18837:
URL: https://github.com/apache/superset/pull/18837#issuecomment-1060615928
After looking at this PR https://github.com/apache/superset/pull/18856 I believe it's best to continue there as it handles other use cases as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org