You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/04 19:59:23 UTC

[GitHub] [hbase] bharathv commented on a change in pull request #2197: HBASE-24807 Backport HBASE-20417 to branch-1

bharathv commented on a change in pull request #2197:
URL: https://github.com/apache/hbase/pull/2197#discussion_r465296034



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceWALReaderThread.java
##########
@@ -132,6 +135,10 @@ public void run() {
       try (WALEntryStream entryStream =
           new WALEntryStream(logQueue, fs, conf, lastReadPosition, metrics)) {
         while (isReaderRunning()) { // loop here to keep reusing stream while we can
+          if (!source.isPeerEnabled()) {

Review comment:
       This is just a safeguard to prevent accumulation of batches right? No other implications of the patch that I can think of.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org