[jira] [Commented] (LANG-1482) Functions

["Peter Verhas (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LANG-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968903#comment-16968903 ] 

Peter Verhas commented on LANG-1482:
------------------------------------

This is a long outstanding pull request. In the meantime, there were some changes that made conflict with the master. I made the resolution. Could someone please review it?

> Functions 
> ----------
>
>                 Key: LANG-1482
>                 URL: https://issues.apache.org/jira/browse/LANG-1482
>             Project: Commons Lang
>          Issue Type: Bug
>          Components: lang.*
>            Reporter: Peter Verhas
>            Priority: Minor
>             Fix For: 3.10
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The implementation of the methods {{asRunnable()}}, {{asConsumer()}}, {{asCallable()}}, {{asBiConsumer()}} etc. is redundant and copy-paste. They are implemented with the structure (example from {{asRunnable()}}:
> {code}
> return () -> {
>             try {
>                 pRunnable.run();
>             } catch (Throwable t) {
>                 throw rethrow(t);
>             }
>         };
> {code}
> This try-catch structure is already implemented in the class and can be used here simplifying the method to 
> {code}
> return () -> run(pRunnable);
> {code}
> Also, the tests for {{asPredicate()}} and {{asBiPredicate()}} are missing.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)