You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/03/08 02:19:00 UTC
[jira] [Work logged] (HIVE-25896) Remove getThreadId from IHMSHandler
[ https://issues.apache.org/jira/browse/HIVE-25896?focusedWorklogId=737904&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-737904 ]
ASF GitHub Bot logged work on HIVE-25896:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/22 02:18
Start Date: 08/Mar/22 02:18
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #3017:
URL: https://github.com/apache/hive/pull/3017#discussion_r821265051
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -287,29 +287,7 @@ PartitionExpressionProxy getExpressionProxy() {
return expressionProxy;
}
- /**
- * Use {@link #getThreadId()} instead.
- * @return thread id
- */
- @Deprecated
- public static Integer get() {
- return HMSHandlerContext.getThreadId();
- }
-
- @Override
- public int getThreadId() {
- return HMSHandlerContext.getThreadId();
- }
-
- public HMSHandler(String name) throws MetaException {
- this(name, MetastoreConf.newMetastoreConf(), true);
- }
-
- public HMSHandler(String name, Configuration conf) throws MetaException {
- this(name, conf, true);
- }
-
- public HMSHandler(String name, Configuration conf, boolean init) throws MetaException {
Review comment:
Hi @pvary, cloud that make sense, what do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 737904)
Time Spent: 1.5h (was: 1h 20m)
> Remove getThreadId from IHMSHandler
> -----------------------------------
>
> Key: HIVE-25896
> URL: https://issues.apache.org/jira/browse/HIVE-25896
> Project: Hive
> Issue Type: Improvement
> Components: Standalone Metastore
> Reporter: Zhihua Deng
> Assignee: Zhihua Deng
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> In IHMSHandler which is annotated as 'InterfaceAudience.Private', we use getThreadId to log the thread information now, the threadId can be logged automatically if we configure the logger properly, the method can be removed for better maintenance of IMSHandler.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)