[GitHub] [spark] constzhou commented on a diff in pull request #35334: [SPARK-38034][SQL] Optimize TransposeWindow rule

[GitBox <gi...@apache.org>]

constzhou commented on code in PR #35334:
URL: https://github.com/apache/spark/pull/35334#discussion_r937314811


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala:
##########
@@ -1148,9 +1148,9 @@ object CollapseWindow extends Rule[LogicalPlan] {
  */
 object TransposeWindow extends Rule[LogicalPlan] {
   private def compatiblePartitions(ps1 : Seq[Expression], ps2: Seq[Expression]): Boolean = {
-    ps1.length < ps2.length && ps2.take(ps1.length).permutations.exists(ps1.zip(_).forall {

Review Comment:
   You mean we should only optimize the performance without changing the logic？Maybe we could find a way to avoid the permutation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org