[GitHub] [hive] thejasmn commented on a change in pull request #1443: Implement jdbc methods invoked by Calcite

[GitBox <gi...@apache.org>]

thejasmn commented on a change in pull request #1443:
URL: https://github.com/apache/hive/pull/1443#discussion_r479722078



##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
##########
@@ -291,7 +291,7 @@ public HiveConnection(String uri, Properties info) throws SQLException {
 
     if (isEmbeddedMode) {
       client = EmbeddedCLIServicePortal.get(connParams.getHiveConfs());
-      connParams.getHiveConfs().clear();
+        connParams.getHiveConfs().clear();

Review comment:
       extra space, pls fix indent

##########
File path: jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java
##########
@@ -1227,4 +1232,13 @@ private TGetInfoResp getServerInfo(TGetInfoType type) throws SQLException {
     Utils.verifySuccess(resp.getStatus());
     return resp;
   }
+
+  private boolean getHiveDefaultNullsLast() {
+    boolean response = ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;

Review comment:
       HIVE_DEFAULT_NULLS_LAST could be overridden on the HiveServer2 using hive-site.xml settings. We need to get a value of this from HS2. 
   I am not sure if we get the current settings from HS2 (i need to check). 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org