[GitHub] [arrow-julia] baumgold commented on pull request #405: do not instantiate new Vector when calling fromarrow

["baumgold (via GitHub)" <gi...@apache.org>]

baumgold commented on PR #405:
URL: https://github.com/apache/arrow-julia/pull/405#issuecomment-1568907469

   > Maybe there's something we can do in the list.jl code or eltypes.jl to say that the variable sized list type returns SubArrays?
   
   I spent some time trying to implement that but couldn't find a clean way to do so.  For `juliaeltype` to return SubArray instead of Vector it would need to know the "parent" type of the SubArray ([parent-type is a type-parameter](https://github.com/JuliaLang/julia/blob/v1.9.0/base/subarray.jl#L14-L24)).  However the "parent" type is deeply embedded in return-type of the [build function](https://github.com/apache/arrow-julia/blob/v2.5.2/src/table.jl#L583).  We could refactor the build functions to separate type calculation from type instantiation so that the calculation part could be reused in the `juliaeltype` function, but that seems like a lot of work so I didn't peruse it yet.  Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org