You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by mb...@apache.org on 2007/12/05 23:45:31 UTC

svn commit: r601559 - in /commons/proper/jxpath/trunk: checkstyle.xml pom.xml

Author: mbenson
Date: Wed Dec  5 14:45:30 2007
New Revision: 601559

URL: http://svn.apache.org/viewvc?rev=601559&view=rev
Log:
checkstyle

Modified:
    commons/proper/jxpath/trunk/checkstyle.xml
    commons/proper/jxpath/trunk/pom.xml

Modified: commons/proper/jxpath/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/checkstyle.xml?rev=601559&r1=601558&r2=601559&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/checkstyle.xml (original)
+++ commons/proper/jxpath/trunk/checkstyle.xml Wed Dec  5 14:45:30 2007
@@ -24,7 +24,7 @@
   -->
   
   <module name="Checker">
-  
+      <property name="localeLanguage" value="en"/>
       <!-- Checks that a package.html file exists for each package.     -->
       <!-- See http://checkstyle.sf.net/config_javadoc.html#PackageHtml -->
       <module name="PackageHtml"/>
@@ -38,16 +38,12 @@
       <module name="Translation"/>
   
       <module name="TreeWalker">
-  
+
           <!--property name="cacheFile" value="${checkstyle.cache.file}"/-->
   
           <!-- ************************************************************** -->
           <!-- Checks that are different from the sun coding conventions ones -->
           <!-- ************************************************************** -->
-          <module name="Header">
-              <property name="headerFile" value="${basedir}/LICENSE.txt"/>
-              <property name="ignoreLines" value="1,2,3,4,5,6"/>
-          </module>
           <property name="tabWidth" value="4"/>
           <module name="LeftCurly">
             <property name="option" value="eol"/>
@@ -74,9 +70,11 @@
   
           <!-- Checks for Javadoc comments.                     -->
           <!-- See http://checkstyle.sf.net/config_javadoc.html -->
-          <module name="JavadocMethod"/>
+          <module name="JavadocMethod">
+            <property name="allowUndeclaredRTE" value="true"/>
+          </module>
           <module name="JavadocType"/>
-          <module name="JavadocVariable"/>
+          <!--module name="JavadocVariable"/-->
   
   
           <!-- Checks for Naming Conventions.                  -->
@@ -135,7 +133,11 @@
           <module name="DoubleCheckedLocking"/>    <!-- MY FAVOURITE -->
           <module name="EmptyStatement"/>
           <module name="EqualsHashCode"/>
-          <module name="HiddenField"/>
+          <!--module name="HiddenField">
+            <property name="ignoreConstructorParameter" value="true" />
+            <property name="ignoreSetter" value="true" />
+            <property name="ignoreAbstractMethods" value="true" />
+          </module-->
           <module name="IllegalInstantiation"/>
           <module name="InnerAssignment"/>
           <module name="MagicNumber"/>
@@ -146,7 +148,6 @@
   
           <!-- Checks for class design                         -->
           <!-- See http://checkstyle.sf.net/config_design.html -->
-          <module name="DesignForExtension"/>
           <module name="FinalClass"/>
           <module name="HideUtilityClassConstructor"/>
           <module name="InterfaceIsType"/>
@@ -156,7 +157,7 @@
           <!-- Miscellaneous other checks.                   -->
           <!-- See http://checkstyle.sf.net/config_misc.html -->
           <module name="ArrayTypeStyle"/>
-          <module name="FinalParameters"/>
+          <!--module name="FinalParameters"/-->
           <module name="GenericIllegalRegexp">
               <property name="format" value="\s+$"/>
               <property name="message" value="Line has trailing spaces."/>

Modified: commons/proper/jxpath/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/jxpath/trunk/pom.xml?rev=601559&r1=601558&r2=601559&view=diff
==============================================================================
--- commons/proper/jxpath/trunk/pom.xml (original)
+++ commons/proper/jxpath/trunk/pom.xml Wed Dec  5 14:45:30 2007
@@ -205,7 +205,6 @@
           <xmlPath>${basedir}/xdocs/changes.xml</xmlPath>
         </configuration>
       </plugin>
-<!--
       <plugin>
         <artifactId>maven-checkstyle-plugin</artifactId>
         <version>2.1</version>
@@ -214,7 +213,6 @@
           <excludes>**/parser/*</excludes>
         </configuration>
       </plugin>
--->
     </plugins>
   </reporting>
   <distributionManagement>