[jira] [Commented] (PLC4X-144) When requesting invalid addresses, the DefaultS7MessageProcessor produces errors

["Christofer Dutz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PLC4X-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952713#comment-16952713 ] 

Christofer Dutz commented on PLC4X-144:
---------------------------------------

The current implementation 0.4.0 didn't inspect the return codes before merging items. This caused problems. This should now be fixed. At least now above example works.

> When requesting invalid addresses, the DefaultS7MessageProcessor produces errors
> --------------------------------------------------------------------------------
>
>                 Key: PLC4X-144
>                 URL: https://issues.apache.org/jira/browse/PLC4X-144
>             Project: Apache PLC4X
>          Issue Type: Bug
>          Components: Driver-S7
>    Affects Versions: 0.4.0
>            Reporter: Christofer Dutz
>            Assignee: Christofer Dutz
>            Priority: Major
>             Fix For: 0.5.0
>
>
> It was reported on StackOverflow that there seem to be errors when simply brute-forcing reading all data from an S7 using PLC4X:
> [https://stackoverflow.com/questions/57607913/unsolvable-error-with-multiple-requested-values-send-to-the-plc-apache-plc4x]
> The issue was easily reproducible using the example code he provided:
>  
> {code:java}
> PlcReadRequest.Builder readBuilder = plcConnection.readRequestBuilder();
> for (int m = 1; m < 10; m++) {
>     for (int j = 1; j < 9; j++) {
>         readBuilder.addItem("value_int " + m + "." + j, "%DB" + m + "." + "DB" + j + ":INT");
>     }
> }
> final PlcReadResponse plcReadResponse = readBuilder.build().execute().get();
> System.out.println(plcReadResponse);{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)