You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/14 10:13:08 UTC

[GitHub] [airflow] potiuk opened a new pull request #5095: [AIRFLOW-4308] Fix DST moving clock backwards on python 3.6

potiuk opened a new pull request #5095: [AIRFLOW-4308] Fix DST moving clock backwards on python 3.6
URL: https://github.com/apache/airflow/pull/5095
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title:
     - https://issues.apache.org/jira/browse/AIRFLOW-4308
   
   ### Description
   
   - [x] Here are some details about my PR, including screenshots of any UI changes:
   
   In case of python 3.6 we want to do the same that pendulum does for python3.5
   i.e in case we move clock back we want to schedule the run at the time of the second
   instance of the same clock time rather than the first one.
   Fold parameter has no impact in other cases so we can safely set it to 1
   
   ### Tests
   
   - [x] My PR adds the following unit tests:
    
   test_dag.DagTest.test_following_previous_schedule_daily_dag_CEST_to_CET  was failing on python 3.6. It should now work fine.
    
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   No need for documentation
   ### Code Quality
   
   - [x] Passes `flake8`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services