You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/25 18:19:49 UTC
[GitHub] [arrow] davisusanibar opened a new pull request, #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
davisusanibar opened a new pull request, #12990:
URL: https://github.com/apache/arrow/pull/12990
Related to https://github.com/apache/arrow/pull/12941#discussion_r856290962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12990:
URL: https://github.com/apache/arrow/pull/12990#issuecomment-1108893311
https://issues.apache.org/jira/browse/ARROW-16292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
URL: https://github.com/apache/arrow/pull/12990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #12990:
URL: https://github.com/apache/arrow/pull/12990#discussion_r857958072
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
+
+.. code-block::
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M6</version>
+ <configuration>
+ <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+Environment variables: To execute your Arrow Java main code.
+
+.. code-block::
+
+ _JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"
Review Comment:
Uhmm, let me figure out if there are some plugins available, but, initially I could say no way to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #12990:
URL: https://github.com/apache/arrow/pull/12990#discussion_r858061202
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
+
+.. code-block::
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M6</version>
+ <configuration>
+ <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+Environment variables: To execute your Arrow Java main code.
+
+.. code-block::
+
+ _JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"
Review Comment:
Ok, sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12990:
URL: https://github.com/apache/arrow/pull/12990#issuecomment-1114414489
Benchmark runs are scheduled for baseline = cb41e069b51d65231cd8dde8bd19ee4fcc4eb9b1 and contender = d46442549d3ff9c4c20646196d02e9cf5ad68c12. d46442549d3ff9c4c20646196d02e9cf5ad68c12 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/345b52044c194b20a9e6146fa2093064...6a4200a2c2e3495d8038914b91372a43/)
[Finished :arrow_down:0.04% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/f0970eb315494347bce0b328771988b7...8f363d4c6068486095c538ab6973c653/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6eb700c493f14d62b3488c6ad6c42ce7...530a2c4cc5f3402bae9800e2997257d6/)
[Finished :arrow_down:0.21% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/bd2ed58c8ea44260a0ba0ea2dba2bf4d...ae93d1332f0f43338967c77f5833b1ce/)
Buildkite builds:
[Finished] [`d4644254` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/639)
[Finished] [`d4644254` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/636)
[Finished] [`d4644254` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/627)
[Finished] [`d4644254` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/639)
[Finished] [`cb41e069` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/638)
[Finished] [`cb41e069` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/635)
[Finished] [`cb41e069` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/626)
[Finished] [`cb41e069` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/638)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #12990:
URL: https://github.com/apache/arrow/pull/12990#discussion_r858060965
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
+
+.. code-block::
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M6</version>
+ <configuration>
+ <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+Environment variables: To execute your Arrow Java main code.
+
+.. code-block::
+
+ _JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"
Review Comment:
There is a [exec-maven-plugin](https://www.mojohaus.org/exec-maven-plugin/) but not able to pass argLine needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] davisusanibar commented on a diff in pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
davisusanibar commented on code in PR #12990:
URL: https://github.com/apache/arrow/pull/12990#discussion_r858060420
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
+
+.. code-block::
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M6</version>
+ <configuration>
+ <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+Environment variables: To execute your Arrow Java main code.
+
+.. code-block::
+
+ _JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"
Review Comment:
Hi @lidavidm, I didn't find a plugin to configure environment variable as needed on the pom.xml directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12990:
URL: https://github.com/apache/arrow/pull/12990#issuecomment-1108893341
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #12990: ARROW-16292: [Java][Doc] Upgrade java documentation for JSE17/JSE18
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #12990:
URL: https://github.com/apache/arrow/pull/12990#discussion_r857938418
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
Review Comment:
This is a little vague. What is needed exactly?
```suggestion
When using Java 17 or later, some JDK internals must be exposed by
adding ``--add-opens=java.base/java.nio=ALL-UNNAMED``. Otherwise,
you may see errors like ``module java.base does not "opens
java.nio" to unnamed module``.
```
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
Review Comment:
```suggestion
For example, when running unit tests through Maven:
```
##########
docs/source/java/install.rst:
##########
@@ -101,6 +101,34 @@ transitive dependencies of Flight.
</build>
</project>
+For users that consume Arrow Java through JSE17/JSE18, please remember to
+add modules needed. As an example if you are testing Java Arrow dependencies
+and seeing error like `module java.base does not opens java.nio` please
+consider to add ``--add-opens=java.base/java.nio=ALL-UNNAMED``.
+
+Plugin configuration: Just for your test execution created.
+
+.. code-block::
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.0.0-M6</version>
+ <configuration>
+ <argLine>--add-opens=java.base/java.nio=ALL-UNNAMED</argLine>
+ </configuration>
+ </plugin>
+ </plugins>
+ </build>
+
+Environment variables: To execute your Arrow Java main code.
+
+.. code-block::
+
+ _JAVA_OPTIONS="--add-opens=java.base/java.nio=ALL-UNNAMED" mvn exec:java -Dexec.mainClass="YourMainCode"
Review Comment:
Can this be configured in `pom.xml` somehow?
##########
docs/source/java/install.rst:
##########
@@ -28,7 +28,7 @@ Java modules are regularly built and tested on macOS and Linux distributions.
Java Compatibility
------------------
-Java modules are currently compatible with JDK 8, 9, 10, or 11, but only JDK 11 is tested in CI.
+Java modules are currently compatible with JDK 8, 9, 10, 11, 17 or 18, but only JDK 11 is tested in CI.
Review Comment:
```suggestion
Java modules are currently compatible with JDK 8, 9, 10, 11, 17, and 18, but only JDK 11 is tested in CI.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org