[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035287#comment-16035287 ] 

ASF GitHub Bot commented on FLINK-6841:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/4061

    [FLINK-6841][table]Using TableSourceTable for both Stream and Batch

    Remove `StreamTableSourceTable`, And using TableSourceTable for both Stream and Batch.
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6841][table]Using TableSourceTable for both Stream and Batch")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6841-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4061.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4061
    
----
commit f17cbd5482e48eb553e3ead5f8f68368beab08cf
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-06-02T19:22:09Z

    [FLINK-6841][table]Using TableSourceTable for both Stream and Batch

----


> using TableSourceTable for both Stream and Batch OR remove useless import
> -------------------------------------------------------------------------
>
>                 Key: FLINK-6841
>                 URL: https://issues.apache.org/jira/browse/FLINK-6841
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> 1. {{StreamTableSourceTable}} exist useless import of {{TableException}}
> 2. {{StreamTableSourceTable}} only override {{getRowType}} of  {{FlinkTable}}, I think we can override the method in {{TableSourceTable}}, If so we can using {{TableSourceTable}} for both {{Stream}} and {{Batch}}.
> What do you think? [~fhueske] [~twalthr]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)