You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2023/01/16 21:58:10 UTC
[GitHub] [logging-log4cxx] timcoleman opened a new issue, #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
timcoleman opened a new issue, #179:
URL: https://github.com/apache/logging-log4cxx/issues/179
When compiled with -Wpedantic, g++ complains of extra semicolons in include/log4cxx/pattern/patternconverter.h in this section:
```
DECLARE_LOG4CXX_PATTERN(PatternConverter);
BEGIN_LOG4CXX_CAST_MAP();
LOG4CXX_CAST_ENTRY(PatternConverter);
END_LOG4CXX_CAST_MAP();
```
since the defines already include semicolons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] timcoleman commented on issue #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
Posted by "timcoleman (via GitHub)" <gi...@apache.org>.
timcoleman commented on issue #179:
URL: https://github.com/apache/logging-log4cxx/issues/179#issuecomment-1399688336
Is that when compiling log4cxx? The warning I got was actually from including the header into my project that uses log4cxx. Sent from my iPhoneOn Jan 22, 2023, at 12:20 PM, Robert Middleton ***@***.***> wrote:
Note: -Wpedantic also leads to other issues with the LOG4CXX_INSTANTIATE_EXPORTED_PTR macro - see this comment for more information.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 closed issue #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 closed issue #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
URL: https://github.com/apache/logging-log4cxx/issues/179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on issue #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on issue #179:
URL: https://github.com/apache/logging-log4cxx/issues/179#issuecomment-1399551471
Note: `-Wpedantic` also leads to other issues with the `LOG4CXX_INSTANTIATE_EXPORTED_PTR` macro - see [this comment](https://github.com/apache/logging-log4cxx/issues/177#issuecomment-1383078063) for more information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4cxx] rm5248 commented on issue #179: Extra semicolons in include/log4cxx/pattern/patternconverter.h
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on issue #179:
URL: https://github.com/apache/logging-log4cxx/issues/179#issuecomment-1399723385
Yes, that is when compiling log4cxx with `-Wpedantic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org