[GitHub] [trafficserver] brbzull0 commented on issue #9343: Add qlog support for quiche

["brbzull0 (via GitHub)" <gi...@apache.org>]

brbzull0 commented on issue #9343:
URL: https://github.com/apache/trafficserver/issues/9343#issuecomment-1442032137

   There isn't much control on our side as you said with the qlog,  the good think is that it works, I may add some error checks when calling quiche as I was testing with some invalid dir and I never knew. 
   
   Also I think we should go for something like this in the config that can let us grow eventually and proivide a more granular configuration:
   ```yaml
   ts:
     quic:
       qlog:
         base_name: /some/dir/test1
   ```
   similiar to what provides `h2load`, 
   ```
   --qlog-file-base=<PATH>                                                      
                 Enable qlog output and specify base file name for qlogs.
                 Qlog is emitted  for each connection.  For  a given base
                 name   "base",    each   output   file    name   becomes         
                 "base.M.N.sqlog" where M is worker ID and N is client ID
                 (e.g. "base.0.3.sqlog").  Only effective in QUIC runs. 
   ```
   You provide a base name, which may include a folder and ATS will append the  trace_id + the extension  to it, so we will end up with something like
   `/some/dur/test1_b5c9cbf4d41cd60c779f059d749dd3cd5b8.sqlog`
   
   1 - @maskit @bryancall  what do you guys think about the config change? It's currently `proxy.config.quic.qlog_dir`?
   
   2 - Also, shouldn't we do this record overridable(conf_remap)? otherwise we may create tons of this if we aren't careful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org