You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2013/06/03 18:32:28 UTC

Review Request: SQOOP-1065 Sqoop2: Remove special lock object in FrameworkManager

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11602/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've removed the lock object and used the class itself.


This addresses bug SQOOP-1065.
    https://issues.apache.org/jira/browse/SQOOP-1065


Diffs
-----

  core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java 145a2c123a6ad239186bd886b994cba6216b78c6 

Diff: https://reviews.apache.org/r/11602/diff/


Testing
-------

Unit and integration tests seems to be passing.


Thanks,

Jarek Cecho


Re: Review Request: SQOOP-1065 Sqoop2: Remove special lock object in FrameworkManager

Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11602/#review22294
-----------------------------------------------------------

Ship it!


- Venkat Ranganathan


On June 22, 2013, 4:30 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11602/
> -----------------------------------------------------------
> 
> (Updated June 22, 2013, 4:30 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Description
> -------
> 
> I've removed the lock object and used the class itself.
> 
> 
> This addresses bug SQOOP-1065.
>     https://issues.apache.org/jira/browse/SQOOP-1065
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java fd9aac91b4623fada4af8c7dc7113ea163fc3019 
> 
> Diff: https://reviews.apache.org/r/11602/diff/
> 
> 
> Testing
> -------
> 
> Unit and integration tests seems to be passing.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request: SQOOP-1065 Sqoop2: Remove special lock object in FrameworkManager

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11602/
-----------------------------------------------------------

(Updated June 22, 2013, 4:30 p.m.)


Review request for Sqoop.


Changes
-------

Rebasing on current head of sqoop2 branch.


Description
-------

I've removed the lock object and used the class itself.


This addresses bug SQOOP-1065.
    https://issues.apache.org/jira/browse/SQOOP-1065


Diffs (updated)
-----

  core/src/main/java/org/apache/sqoop/framework/JobManager.java fd9aac91b4623fada4af8c7dc7113ea163fc3019 

Diff: https://reviews.apache.org/r/11602/diff/


Testing
-------

Unit and integration tests seems to be passing.


Thanks,

Jarek Cecho