You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Benchao Li (Jira)" <ji...@apache.org> on 2020/08/28 12:29:00 UTC
[jira] [Commented] (FLINK-19050) Doc of MAX_DECIMAL_PRECISION
should be DECIMAL
[ https://issues.apache.org/jira/browse/FLINK-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186512#comment-17186512 ]
Benchao Li commented on FLINK-19050:
------------------------------------
fixed via b5a459c6d11fc7d655e7bcf26a8cea0594a693dd (1.12.0)
> Doc of MAX_DECIMAL_PRECISION should be DECIMAL
> ----------------------------------------------
>
> Key: FLINK-19050
> URL: https://issues.apache.org/jira/browse/FLINK-19050
> Project: Flink
> Issue Type: Bug
> Components: Documentation
> Affects Versions: 1.11.1
> Reporter: Pua
> Assignee: Pua
> Priority: Trivial
> Labels: pull-request-available
>
> {code:java}
> // Define MAX/MIN precision of TIMESTAMP type according to PostgreSQL docs:
> // https://www.postgresql.org/docs/12/datatype-numeric.html#DATATYPE-NUMERIC-DECIMAL
> private static final int MAX_DECIMAL_PRECISION = 1000;
> private static final int MIN_DECIMAL_PRECISION = 1;
> {code}
> [https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/PostgresDialect.java#L43]
> the doc of decimal precision constants should be DECIMAL not TIMESTAMP
--
This message was sent by Atlassian Jira
(v8.3.4#803005)