You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2013/07/15 14:29:28 UTC
Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Repository: cloudstack-git
Description
-------
Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
Diffs
-----
test/integration/smoke/test_network.py 6788dca
Diff: https://reviews.apache.org/r/12546/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23363
-----------------------------------------------------------
Commit e25cbd66d2b13db684f2f339b05aafa6b119bcfe in branch refs/heads/master from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=e25cbd6 ]
CLOUDSTACK-3168: Change in try_ssh function
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On July 18, 2013, 8:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 8:45 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_loadbalance.py 7bf560c
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23365
-----------------------------------------------------------
Ship it!
Ship It!
- Prasanna Santhanam
On July 18, 2013, 8:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 8:45 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_loadbalance.py 7bf560c
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23361
-----------------------------------------------------------
Commit f2d9a7b659087e599494ca98f7cfed2721179c49 in branch refs/heads/4.2 from Gaurav Aradhye
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f2d9a7b ]
CLOUDSTACK-3168: Change in try_ssh function
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit e25cbd66d2b13db684f2f339b05aafa6b119bcfe)
- ASF Subversion and Git Services
On July 18, 2013, 8:45 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 18, 2013, 8:45 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_loadbalance.py 7bf560c
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Gaurav Aradhye <ga...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/
-----------------------------------------------------------
(Updated July 18, 2013, 8:45 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
Updated the diff for 4.2 branch. This patch needs to be applied after the b8d876fff806e33e859016c252bd208c1ea28c2d" commit in this branch.
Repository: cloudstack-git
Description
-------
Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
Diffs (updated)
-----
test/integration/smoke/test_loadbalance.py 7bf560c
Diff: https://reviews.apache.org/r/12546/diff/
Testing
-------
Thanks,
Gaurav Aradhye
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 15, 2013, 1:07 p.m., Prasanna Santhanam wrote:
> > This won't apply as it was already resolved in b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of master? Can you please check?
>
> Gaurav Aradhye wrote:
> Hi Prasanna,
>
> The commit "b8d876fff806e33e859016c252bd208c1ea28c2d" is absent in branch master-6-17-stable branch. It's present in master. I think we have missed this.
> Also the change in try_ssh function was absent in above commit, which is present in this diff as it is logically a generic function now.
> The function try_ssh was earlier reading ip address by reading from object and it is used in two test cases. To avoid confusion I have made it to accept directly ip address.
Thanks - in that case we'll need only one patch here. One for master/4.2 where you only change the try_ssh(). I'll cherry-pick over b8d876fff806e33e859016c252bd208c1ea28c2d and the fresh patch into master-6-17 if that's where you are testing this from.
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23147
-----------------------------------------------------------
On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 12:29 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 6788dca
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On July 15, 2013, 1:07 p.m., Prasanna Santhanam wrote:
> > This won't apply as it was already resolved in b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of master? Can you please check?
>
> Gaurav Aradhye wrote:
> Hi Prasanna,
>
> The commit "b8d876fff806e33e859016c252bd208c1ea28c2d" is absent in branch master-6-17-stable branch. It's present in master. I think we have missed this.
> Also the change in try_ssh function was absent in above commit, which is present in this diff as it is logically a generic function now.
> The function try_ssh was earlier reading ip address by reading from object and it is used in two test cases. To avoid confusion I have made it to accept directly ip address.
>
> Prasanna Santhanam wrote:
> Thanks - in that case we'll need only one patch here. One for master/4.2 where you only change the try_ssh(). I'll cherry-pick over b8d876fff806e33e859016c252bd208c1ea28c2d and the fresh patch into master-6-17 if that's where you are testing this from.
Ok do you want me to update the diff with only change in try_ssh ?
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23147
-----------------------------------------------------------
On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 12:29 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 6788dca
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Prasanna Santhanam <ts...@apache.org>.
> On July 15, 2013, 1:07 p.m., Prasanna Santhanam wrote:
> > This won't apply as it was already resolved in b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of master? Can you please check?
>
> Gaurav Aradhye wrote:
> Hi Prasanna,
>
> The commit "b8d876fff806e33e859016c252bd208c1ea28c2d" is absent in branch master-6-17-stable branch. It's present in master. I think we have missed this.
> Also the change in try_ssh function was absent in above commit, which is present in this diff as it is logically a generic function now.
> The function try_ssh was earlier reading ip address by reading from object and it is used in two test cases. To avoid confusion I have made it to accept directly ip address.
>
> Prasanna Santhanam wrote:
> Thanks - in that case we'll need only one patch here. One for master/4.2 where you only change the try_ssh(). I'll cherry-pick over b8d876fff806e33e859016c252bd208c1ea28c2d and the fresh patch into master-6-17 if that's where you are testing this from.
>
> Gaurav Aradhye wrote:
> Ok do you want me to update the diff with only change in try_ssh ?
That's Correct. Just the updated diff for fixing the issue for VmWare for which the bug was reopened
- Prasanna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23147
-----------------------------------------------------------
On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 12:29 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 6788dca
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On July 15, 2013, 1:07 p.m., Prasanna Santhanam wrote:
> > This won't apply as it was already resolved in b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of master? Can you please check?
Hi Prasanna,
The commit "b8d876fff806e33e859016c252bd208c1ea28c2d" is absent in branch master-6-17-stable branch. It's present in master. I think we have missed this.
Also the change in try_ssh function was absent in above commit, which is present in this diff as it is logically a generic function now.
The function try_ssh was earlier reading ip address by reading from object and it is used in two test cases. To avoid confusion I have made it to accept directly ip address.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23147
-----------------------------------------------------------
On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 12:29 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 6788dca
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 12546: CLOUDSTACK-3168: test_network.py - Changed try_ssh
function defn. Resolved Object NoneType issues
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12546/#review23147
-----------------------------------------------------------
This won't apply as it was already resolved in b8d876fff806e33e859016c252bd208c1ea28c2d. Is there a new diff on top of master? Can you please check?
- Prasanna Santhanam
On July 15, 2013, 12:29 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12546/
> -----------------------------------------------------------
>
> (Updated July 15, 2013, 12:29 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved CLOUDSTACK-3168: Changed try_ssh function defn. Now it directly accepts ip address as parameter instead of reading it from object l
> ater. This resolves object Nonetype issues which were arising due to passing wrong parameter as ip address
>
>
> Diffs
> -----
>
> test/integration/smoke/test_network.py 6788dca
>
> Diff: https://reviews.apache.org/r/12546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>