You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrew Gaul <no...@github.com> on 2014/10/12 22:49:38 UTC
[jclouds] Fix GuiceAssistedInjectScoping error-prone warning (#571)
You can merge this Pull Request by running:
git pull https://github.com/andrewgaul/jclouds error-prone-guice
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds/pull/571
-- Commit Summary --
* Fix GuiceAssistedInjectScoping error-prone warning
-- File Changes --
M apis/cloudstack/src/main/java/org/jclouds/cloudstack/functions/StaticNATVirtualMachineInNetwork.java (2)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/LocationIdToURIFromAccessForTypeAndVersion.java (2)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/RegionIdToAdminURIFromAccessForTypeAndVersion.java (2)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/RegionIdToURIFromAccessForTypeAndVersion.java (2)
M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/suppliers/ZoneIdToURIFromAccessForTypeAndVersion.java (2)
M apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/RegionIdToURIFromAuthForServiceSupplier.java (2)
M apis/rackspace-cloudidentity/src/main/java/org/jclouds/rackspace/cloudidentity/v1_1/suppliers/V1DefaultRegionIdSupplier.java (2)
M common/openstack/src/main/java/org/jclouds/openstack/functions/URIFromAuthenticationResponseForService.java (2)
M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/suppliers/RegionIdToURIFromAuthForServiceSupplier.java (2)
M common/openstack/src/main/java/org/jclouds/openstack/keystone/v1_1/suppliers/V1DefaultRegionIdSupplier.java (2)
M core/src/main/java/org/jclouds/location/suppliers/fromconfig/LocationIdToURIFromConfigurationOrDefaultToProvider.java (2)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/suppliers/CallForImages.java (2)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/571.patch
https://github.com/jclouds/jclouds/pull/571.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me too. Thanks, @andrewgaul!
Is this a pattern we could add to Checkstyle and/or something like error-prone? It seems like `@Singleton` and `@Assisted` shouldn't appear in the same class?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58826087
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-6 #197](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-6/197/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58821980
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Adrian Cole <no...@github.com>.
+1 yeap we over-stamp singleton on things, and it makes no sense on a object returned from an assisted factory
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58823392
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Andrew Phillips <no...@github.com>.
> As suggested in the commit message, error-prone emitted this warning
Ahh...sorry, didn't get that first time around ;-) Thanks for explaining!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58834497
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Andrew Gaul <no...@github.com>.
As suggested in the commit message, error-prone emitted this warning.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58826390
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1787](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1787/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58825199
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Andrew Gaul <no...@github.com>.
Pushed to master as 489850d7db58552a1181672111c035ebd116cc4d.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58825959
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1286](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1286/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58822878
Re: [jclouds] Fix GuiceAssistedInjectScoping error-prone warning
(#571)
Posted by Andrew Gaul <no...@github.com>.
I believe this is correct but would appreciate feedback from someone more experienced with Guice.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/571#issuecomment-58821953