[GitHub] michellethomas opened a new pull request #6956: [WIP] Adding custom control overrides

[GitBox <gi...@apache.org>]

michellethomas opened a new pull request #6956: [WIP] Adding custom control overrides
URL: https://github.com/apache/incubator-superset/pull/6956
 
 
   In our deployment we need to add custom control overrides. I'm trying to find a way to add this into superset in a way that allows us to avoid maintaining cherry picks. I have a method that overrides files using NormalModuleReplacementPlugin during deployment in a webpack config that merges with the open source config (I'll add docs for this process). 
   
   In order to easily override files, I need to make a few changes I've included in this PR.
   
   I also have a fix for MetricsControl, isEqual was not being used correctly and doesn't catch in the case that the objects are different lengths. And we were also clearing metrics control too frequently, we only need to clear when the changed metrics list no longer contains the selected metric.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org