You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Eugene Chekanskiy <ec...@hortonworks.com> on 2017/11/28 13:17:33 UTC
Review Request 64118: Refactor internal code of handling info between
kerberos wizard actions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530
Repository: ambari
Description
-------
Moved out of data files for principal generation.
Now before every kerberos action all info written to database.
Server actions determine what principals to process based on filters passed to action, this allow:
* selective generation
* split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
Diff: https://reviews.apache.org/r/64118/diff/1/
Testing
-------
manual testing, all kind of regenerate keytabs
unit tests updating in progress
Thanks,
Eugene Chekanskiy
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
> > Lines 614-616 (original), 616-618 (patched)
> > <https://reviews.apache.org/r/64118/diff/1/?file=1902406#file1902406line620>
> >
> > It seems like `service`, `component`, and `principal` are not needed here anymore. Maybe we should remove them from the Heartbeat request and response structures. This will require some changes on the agent side as well.
As for now I removed service and component, because it is really not needed by agent, but principal field will become List in future, as it will represent list of principals for each keytab. But this will be changed
> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
> > Lines 1902-1903 (original), 1921-1953 (patched)
> > <https://reviews.apache.org/r/64118/diff/1/?file=1902410#file1902410line1923>
> >
> > It seems like this could be simplified using more _JPA-like_ logic. Someone with more experience with JPA (than me) should probably take a look.
I guess it can, I will try. But service-component mapping will require creating of additional entity. But maybe it will be simpler than current variant.
> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 938 (patched)
> > <https://reviews.apache.org/r/64118/diff/1/?file=1902432#file1902432line938>
> >
> > Technially, this _unnatural_ key is not necessary since you have a valid _natural_ key - principal, keytab, component, service.
This is done to avoid one-to-many between KerberosKeytabPrincipalEntity and HostEntity, and indicate that principals with kkp_id=-1 belongs to ambari-server only, and still have mapping to host. So for cases when ambari-server host does not have ambari agent, host_id will be null and kkp_id -1.
> On Nov. 28, 2017, 8:59 p.m., Robert Levas wrote:
> > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> > Lines 945 (patched)
> > <https://reviews.apache.org/r/64118/diff/1/?file=1902432#file1902432line945>
> >
> > Should host_id be part of this?
see comment above, host_id=kkp_id or host_id=null kkp_id=-1.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192040
-----------------------------------------------------------
On Nov. 28, 2017, 1:17 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 1:17 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/1/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> unit tests updating in progress
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192040
-----------------------------------------------------------
This is looking realy good. You need to add upgrade logic and fix the ignored tests.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
Lines 614-616 (original), 616-618 (patched)
<https://reviews.apache.org/r/64118/#comment270028>
It seems like `service`, `component`, and `principal` are not needed here anymore. Maybe we should remove them from the Heartbeat request and response structures. This will require some changes on the agent side as well.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
Lines 640-642 (original), 650-652 (patched)
<https://reviews.apache.org/r/64118/#comment270029>
It seems like `service`, `component`, and `principal` are not needed here anymore. Maybe we should remove them from the Heartbeat request and response structures. This will require some changes on the agent side as well.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Line 446 (original), 451 (patched)
<https://reviews.apache.org/r/64118/#comment270027>
It seems like `principal` may not be needed here anymore. Maybe we should remove it from the Heartbeat request and response structures.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Lines 458-459 (original), 466-467 (patched)
<https://reviews.apache.org/r/64118/#comment270031>
This seems incorrect (I know it was pre-existing code). The same path for some keytab files may be on several hosts. If only a single host has a keytab file removed, it seems like the DB will be updated incorrectly and remove all entries for a keytab file path regardless of host.
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Lines 470-471 (original), 480-481 (patched)
<https://reviews.apache.org/r/64118/#comment270032>
This should be reverted back. The existing implementation is correct. I assume this is a merge issue.
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Lines 1902-1903 (original), 1921-1953 (patched)
<https://reviews.apache.org/r/64118/#comment270034>
It seems like this could be simplified using more _JPA-like_ logic. Someone with more experience with JPA (than me) should probably take a look.
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Line 2421 (original), 2437-2441 (patched)
<https://reviews.apache.org/r/64118/#comment270037>
This syntax is typcially avoided. Are there any `com.google.common.collect` utilities that can be used?
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java
Line 57 (original), 60-68 (patched)
<https://reviews.apache.org/r/64118/#comment270039>
Cascading should be setup to avoid having to do this.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
Line 120 (original), 120 (patched)
<https://reviews.apache.org/r/64118/#comment270055>
Use `RootService.AMBARI.name()` instead of `"AMBARI"`
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java
Lines 63-64 (original), 59-60 (patched)
<https://reviews.apache.org/r/64118/#comment270057>
The logic below is needed when Kerberos is enabled during a Blueprint install. Due to the order of operations, any shared keytab files (like spnego.service.keytab) will be initially owned and accessible only by the user executing Ambari. This is due to the lack of accounts and groups on the Ambari server host.
For example, when enabling Kerberos the Ambari server host's SPNEGO principal is created for Ambari as well as some services that may reside on that host. At the time the Ambari server's keytab files are created, the needed users and groups may not have been created. Like `${cluster-env/user_group}` which defaults to `hadoop`.
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 938 (patched)
<https://reviews.apache.org/r/64118/#comment270070>
Technially, this _unnatural_ key is not necessary since you have a valid _natural_ key - principal, keytab, component, service.
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
Lines 945 (patched)
<https://reviews.apache.org/r/64118/#comment270071>
Should host_id be part of this?
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
Line 934 (original), 940 (patched)
<https://reviews.apache.org/r/64118/#comment270062>
This should be renamed to `PK_kerberos_keytab`
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
Lines 963-965 (patched)
<https://reviews.apache.org/r/64118/#comment270072>
Test this on MySQL.. The creation of this table may fail due to lack of indices on the related fields.
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
Line 913 (original), 919 (patched)
<https://reviews.apache.org/r/64118/#comment270063>
This should be renamed to `PK_kerberos_keytab`
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Line 916 (original), 922 (patched)
<https://reviews.apache.org/r/64118/#comment270064>
This should be renamed to `PK_kerberos_keytab`
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql
Line 912 (original), 918 (patched)
<https://reviews.apache.org/r/64118/#comment270065>
This should be renamed to `PK_kerberos_keytab`
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql
Line 936 (original), 942 (patched)
<https://reviews.apache.org/r/64118/#comment270066>
This should be renamed to `PK_kerberos_keytab`
- Robert Levas
On Nov. 28, 2017, 8:17 a.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2017, 8:17 a.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/1/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> unit tests updating in progress
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
> On Nov. 29, 2017, 5:40 p.m., Attila Magyar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
> > Lines 4017 (patched)
> > <https://reviews.apache.org/r/64118/diff/2/?file=1903755#file1903755line4076>
> >
> > what's the difference between assemblying this JsonObjet by hand or just serializing with gson.toJson(serviceComponentFilter) ?
gson.toJson just does not work. As far as I remember it can serialize Map<Key, SomePrimitiveType> only.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192141
-----------------------------------------------------------
On Nov. 29, 2017, 5:14 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:14 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/2/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review192141
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
Lines 4017 (patched)
<https://reviews.apache.org/r/64118/#comment270167>
what's the difference between assemblying this JsonObjet by hand or just serializing with gson.toJson(serviceComponentFilter) ?
- Attila Magyar
On Nov. 29, 2017, 5:14 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2017, 5:14 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/2/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
> On Dec. 12, 2017, 6:54 p.m., Robert Levas wrote:
> > This is looking really good. Upgrade logic to the appropriate UpgradeCatalog class.
Upgrade will be seperate patch. I want to finish server and agent side changes to implement upgrade after all tables and data are stable.
> On Dec. 12, 2017, 6:54 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
> > Lines 456-464 (patched)
> > <https://reviews.apache.org/r/64118/diff/3/?file=1909894#file1909894line464>
> >
> > Did you intend to leave this here, or will it be fixed before this is committed?
Most likely it will be removed after agent side refactoring. On final stage of refactoring all TODOs will be reviewed and removed.
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review193576
-----------------------------------------------------------
On Dec. 13, 2017, 6:14 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 6:14 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/4/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review193576
-----------------------------------------------------------
This is looking really good. Upgrade logic to the appropriate UpgradeCatalog class.
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
Line 605 (original), 603 (patched)
<https://reviews.apache.org/r/64118/#comment272149>
Change thChange this to use `DigestUtils.sha256Hex` for security concious folks... I know this is not being used in a security-related context, but SHA1 is being frowned upon.is to `DigestUtils.sha256`
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
Lines 456-464 (patched)
<https://reviews.apache.org/r/64118/#comment272144>
Did you intend to leave this here, or will it be fixed before this is committed?
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
Line 127 (original), 137 (patched)
<https://reviews.apache.org/r/64118/#comment272150>
Change this to use `DigestUtils.sha256Hex` for security concious folks... I know this is not being used in a security-related context, but SHA1 is being frowned upon.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
Line 121 (original), 119 (patched)
<https://reviews.apache.org/r/64118/#comment272146>
We should change from SHA1 to SHA256 for security concious people.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
Line 209 (original), 205 (patched)
<https://reviews.apache.org/r/64118/#comment272148>
Change this to use `DigestUtils.sha256Hex` for security concious folks... I know this is not being used in a security-related context, but SHA1 is being frowned upon.
- Robert Levas
On Dec. 6, 2017, 5:21 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2017, 5:21 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/3/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Attila Magyar <am...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review194329
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Magyar
On Dec. 13, 2017, 6:14 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 6:14 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/4/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/#review194176
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Dec. 13, 2017, 1:14 p.m., Eugene Chekanskiy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64118/
> -----------------------------------------------------------
>
> (Updated Dec. 13, 2017, 1:14 p.m.)
>
>
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
>
>
> Bugs: AMBARI-22530
> https://issues.apache.org/jira/browse/AMBARI-22530
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Moved out of data files for principal generation.
> Now before every kerberos action all info written to database.
>
> Server actions determine what principals to process based on filters passed to action, this allow:
>
> * selective generation
> * split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
> ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
> ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
> ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
> ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
> ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
>
>
> Diff: https://reviews.apache.org/r/64118/diff/4/
>
>
> Testing
> -------
>
> manual testing, all kind of regenerate keytabs
> mvn clean test
>
>
> Thanks,
>
> Eugene Chekanskiy
>
>
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
-----------------------------------------------------------
(Updated Dec. 13, 2017, 6:14 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530
Repository: ambari
Description
-------
Moved out of data files for principal generation.
Now before every kerberos action all info written to database.
Server actions determine what principals to process based on filters passed to action, this allow:
* selective generation
* split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
Diff: https://reviews.apache.org/r/64118/diff/4/
Changes: https://reviews.apache.org/r/64118/diff/3-4/
Testing
-------
manual testing, all kind of regenerate keytabs
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
-----------------------------------------------------------
(Updated Dec. 6, 2017, 10:21 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530
Repository: ambari
Description
-------
Moved out of data files for principal generation.
Now before every kerberos action all info written to database.
Server actions determine what principals to process based on filters passed to action, this allow:
* selective generation
* split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 52ab9b56ae
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabServiceMappingEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
Diff: https://reviews.apache.org/r/64118/diff/3/
Changes: https://reviews.apache.org/r/64118/diff/2-3/
Testing
-------
manual testing, all kind of regenerate keytabs
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:14 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530
Repository: ambari
Description
-------
Moved out of data files for principal generation.
Now before every kerberos action all info written to database.
Server actions determine what principals to process based on filters passed to action, this allow:
* selective generation
* split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
Diff: https://reviews.apache.org/r/64118/diff/2/
Testing (updated)
-------
manual testing, all kind of regenerate keytabs
mvn clean test
Thanks,
Eugene Chekanskiy
Re: Review Request 64118: Refactor internal code of handling info
between kerberos wizard actions
Posted by Eugene Chekanskiy <ec...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64118/
-----------------------------------------------------------
(Updated Nov. 29, 2017, 5:12 p.m.)
Review request for Ambari, Attila Magyar, Balázs Bence Sári, and Robert Levas.
Changes
-------
Addresed some of the issues, fixed ignored unit tests
Bugs: AMBARI-22530
https://issues.apache.org/jira/browse/AMBARI-22530
Repository: ambari
Description
-------
Moved out of data files for principal generation.
Now before every kerberos action all info written to database.
Server actions determine what principals to process based on filters passed to action, this allow:
* selective generation
* split generation process per-host/per-service/per-component basis and make generation concurrent for seperate parts
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java 53cceb0ded
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java 83d2c9808d
ambari-server/src/main/java/org/apache/ambari/server/controller/DeleteIdentityHandler.java a7b9d80df0
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java 749943dc00
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java ab85aa1d7c
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java 06725003bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabDAO.java a8723b7bfa
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosKeytabPrincipalDAO.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalDAO.java 81e4b3d0bf
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/KerberosPrincipalHostDAO.java f27dc48ea4
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostGroupComponentEntityPK.java 0898133bb5
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabEntity.java a25931b946
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntity.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosKeytabPrincipalEntityPK.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalEntity.java 5dd54ca30c
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntity.java d4e80c65d2
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/KerberosPrincipalHostEntityPK.java 7e57e4ae95
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java b8affb4e19
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CleanupServerAction.java 002076d85c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java 338415280f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java 5ec4c1011e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java 0c906592af
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java 4c80bd425e
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerAction.java bfd5e4036d
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java ff5f5cef1c
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 671ad95c8f
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java 83a2106afd
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/KerberosKeytabController.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java 17e484ad10
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosPrincipal.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosAction.java ca78dbb8a2
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java 5ac1ac316d
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7045240b30
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c950c7ef83
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 537ae196c5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql b4952c2e86
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 4fb0d0981a
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 8a88aba905
ambari-server/src/main/resources/META-INF/persistence.xml 686c8312cd
ambari-server/src/test/java/org/apache/ambari/server/agent/TestHeartbeatHandler.java b4ff5c10ab
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java ee87d24d8a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 59fbba0eac
ambari-server/src/test/java/org/apache/ambari/server/orm/db/DDLTests.java 96cf64e53c
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerActionTest.java 39dee24ad4
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/FinalizeKerberosServerActionTest.java c9301f3b7e
ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java e6f0868360
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/PreconfigureKerberosActionTest.java a08f7a0a25
Diff: https://reviews.apache.org/r/64118/diff/2/
Changes: https://reviews.apache.org/r/64118/diff/1-2/
Testing
-------
manual testing, all kind of regenerate keytabs
unit tests updating in progress
Thanks,
Eugene Chekanskiy