[GitHub] [flink] reswqa commented on a diff in pull request #20796: [FLINK-29238][runtime] Wrong index information will be obtained after the downstream failover in hybrid full mode

[GitBox <gi...@apache.org>]

reswqa commented on code in PR #20796:
URL: https://github.com/apache/flink/pull/20796#discussion_r969077225


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsSubpartitionView.java:
##########
@@ -85,10 +86,12 @@ public BufferAndBacklog getNextBuffer() {
                 updateConsumingStatus(bufferToConsume);
                 return bufferToConsume.map(this::handleBacklog).orElse(null);
             } catch (Throwable cause) {
-                releaseInternal(cause);
-                return null;
+                readError = cause;
             }
         }
+        // release subpartition reader outside of lock to avoid deadlock.
+        releaseInternal(readError);
+        return null;

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org