You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/06 17:33:58 UTC

[GitHub] [incubator-pekko-http] kw217 opened a new pull request, #20: Record fork base commit and version in README

kw217 opened a new pull request, #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20

   It's useful for potential users of Pekko to know what version of Akka it corresponds to. This PR adds that info to the README. It also adds the precise commit of the fork, since that's likely to be of interest to us and to others in the future.
   
   I'd like to propose tagging that commit as well, as `akka-fork-base` or similar - do you agree this would be a good idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on pull request #20: Record fork base commit and version in README

Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20#issuecomment-1373967607

   I've added a git tag - see https://github.com/apache/incubator-pekko-http/tags and would be -1 on this PR - I think the tag is enough.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning merged pull request #20: Record fork base commit and version in README

Posted by GitBox <gi...@apache.org>.
pjfanning merged PR #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on pull request #20: Record fork base commit and version in README

Posted by GitBox <gi...@apache.org>.
pjfanning commented on PR #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20#issuecomment-1373977189

   I'm happy with the current pekko repo text.
   
   ```
   Pekko is a fork of [Akka](https://github.com/akka/akka) 2.6.x, prior to the Akka project's adoption of the Business Source License.
   ```
   
   So for pekko-http, we can use.
   
   ```
   Pekko-Http is a fork of [Akka-Http](https://github.com/akka/akka-http) 10.2.x, prior to the Akka project's adoption of the Business Source License.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] kw217 commented on pull request #20: Record fork base commit and version in README

Posted by GitBox <gi...@apache.org>.
kw217 commented on PR #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20#issuecomment-1373970396

   Thanks for the tag. Would you accept the PR if I remove the commit link? I think the base version is very important - I just worked it out so I can see whether my current project will be able to move across smoothly or not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] kw217 commented on pull request #20: Record fork base commit and version in README

Posted by GitBox <gi...@apache.org>.
kw217 commented on PR #20:
URL: https://github.com/apache/incubator-pekko-http/pull/20#issuecomment-1375299818

   Thanks @pjfanning - done. That, plus the new tag, is sufficient for me :-). Please can you approve the workflow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org