You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/03/22 04:17:28 UTC

[GitHub] [orc] wgtmac opened a new pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

wgtmac opened a new pull request #661:
URL: https://github.com/apache/orc/pull/661


   ### What changes were proposed in this pull request?
   The Java ORC reader takes one second off from timestamp values with negative second and nanosecond greater than 999999. The C++ ORC reader/writer should use same logic to be consistent.
   
   ### Why are the changes needed?
   WIthout this fix, we may see data inconsistency of timestamp values from different ORC readers.
   
   ### How was this patch tested?
   It can be tested manually by C++/Java ORC tools.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #661:
URL: https://github.com/apache/orc/pull/661#issuecomment-804787994


   Thank you, @dongjoon-hyun and @pgaref .
   Merged to master. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #661:
URL: https://github.com/apache/orc/pull/661#issuecomment-804795547


   This is backported to branch-1.6, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #661:
URL: https://github.com/apache/orc/pull/661#issuecomment-804602374


   Thank you for adding the test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #661:
URL: https://github.com/apache/orc/pull/661


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] pgaref commented on pull request #661: ORC-763: [C++] Fix ORC timestamp inconsistencies with Java ORC

Posted by GitBox <gi...@apache.org>.
pgaref commented on pull request #661:
URL: https://github.com/apache/orc/pull/661#issuecomment-804819046


   Thanks for the fix @wgtmac ! 
   I was thinking about the backport too, thanks @dongjoon-hyun ! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org