You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/04/27 06:06:37 UTC

[GitHub] [kyuubi] codecov-commenter commented on pull request #4777: Make EventHandler auto-closeable and de-register all event handlers when stopping server

codecov-commenter commented on PR #4777:
URL: https://github.com/apache/kyuubi/pull/4777#issuecomment-1524791911

   ## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4777](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (648471b) into [master](https://codecov.io/gh/apache/kyuubi/commit/0b72a6151cf8441e51592a5eb7c4b7816898e41a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b72a61) will **decrease** coverage by `0.05%`.
   > The diff coverage is `84.21%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4777      +/-   ##
   ============================================
   - Coverage     57.98%   57.94%   -0.05%     
     Complexity       13       13              
   ============================================
     Files           581      581              
     Lines         32423    32454      +31     
     Branches       4309     4313       +4     
   ============================================
   + Hits          18801    18804       +3     
   - Misses        11822    11837      +15     
   - Partials       1800     1813      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ala/org/apache/kyuubi/events/handler/package.scala](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWV2ZW50cy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvaGFuZGxlci9wYWNrYWdlLnNjYWxh) | `25.00% <50.00%> (+25.00%)` | :arrow_up: |
   | [...main/scala/org/apache/kyuubi/events/EventBus.scala](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWV2ZW50cy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvRXZlbnRCdXMuc2NhbGE=) | `82.69% <83.33%> (+0.47%)` | :arrow_up: |
   | [...yuubi/events/handler/JsonLoggingEventHandler.scala](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWV2ZW50cy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9ldmVudHMvaGFuZGxlci9Kc29uTG9nZ2luZ0V2ZW50SGFuZGxlci5zY2FsYQ==) | `83.67% <90.00%> (+0.74%)` | :arrow_up: |
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/kyuubi/pull/4777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `53.84% <100.00%> (ø)` | |
   
   ... and [13 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4777/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org