You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mesos Reviewbot Windows <re...@mesos.apache.org> on 2017/08/11 15:44:38 UTC
Re: Review Request 61118: WIP: Building gRPC support in libprocess
with CMake.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61118/#review182707
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61488, 61489, 61508, 61509, 61095, 61576, 61097, 61098, 61433, 61517, 61159, 61160, 61096, 61118]
Logs available here: http://104.210.40.105/logs/master/61118
- Mesos Reviewbot Windows
On Aug. 4, 2017, 11:21 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61118/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2017, 11:21 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-7810
> https://issues.apache.org/jira/browse/MESOS-7810
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables CMake to build code for gRPC support in libprocess
> along with tests under Linux.
>
> TODO(chhsiao): gRPC support for Windows.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/CMakeLists.txt f97291bd7cadcb440231619a8a2d1029a447ec27
> 3rdparty/libprocess/src/tests/CMakeLists.txt 27451c275b1f5a2eb7ada78f8cbe4b7c2c63ca92
>
>
> Diff: https://reviews.apache.org/r/61118/diff/3/
>
>
> Testing
> -------
>
> make
> sudo make check
> cd 3rdparty/libprocess/src/tests && make libprocess-tests && ./libprocess-tests
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>