You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2015/11/19 11:31:56 UTC
[GitHub] incubator-zeppelin pull request: [Zeppelin-136] Zeppelin delete pa...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/451
[Zeppelin-136] Zeppelin delete paragraph content after 'Move up'
Zeppelin doesn't keep the text change in editor if user tries to "Move up" or "Move down" the paragraph before "auto save"(which is introduced by #168) triggered.
Description of this PR:
* Save moving paragraphs before changing the paragraph location.
* removed unnecessary element
* changed dirty text condition ( color of editor bar is always grey when there is no text, but it should be orange when user is erasing all the text )
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-136
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/451.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #451
----
commit 855238608509abab39cbf70857d3e819d18259ad
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-11-19T09:56:16Z
[ZEPPELIN-136] zeppelin delete paragraph content after 'Move up' operation
commit d1e628750b0f3a116420b18e162977ed3bd66085
Author: Mina Lee <mi...@nflabs.com>
Date: 2015-11-19T09:57:20Z
[ZEPPELIN-136] Remove unnecessary element and change dirty text condition
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-136] Zeppelin delete pa...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/451#issuecomment-158329867
Thanks for nice fix.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-136] Zeppelin delete pa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: [Zeppelin-136] Zeppelin delete pa...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/451#issuecomment-158598786
Merge if there're no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---