You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Viknes B <vi...@msn.com> on 2012/06/26 22:25:26 UTC
Review Request: Friend Gadget
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5596/
-----------------------------------------------------------
Review request for rave and Raminder Singh.
Description
-------
To begin with for RAVE-690, Added friend gadget and made changes in DB to populate friend
This addresses bug RAVE-690.
https://issues.apache.org/jira/browse/RAVE-690
Diffs
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friends.xml PRE-CREATION
https://svn.apache.org/repos/asf/rave/trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1354165
Diff: https://reviews.apache.org/r/5596/diff/
Testing
-------
Thanks,
Viknes B
Re: Review Request: Friend Gadget
Posted by Raminder Singh <ra...@apache.org>.
> On June 29, 2012, 1:58 p.m., Raminder Singh wrote:
> > Ship It!
I tested the gadget and its working fine. i will make the change in initial_data.sql to add this gadget to widget store.
- Raminder
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5596/#review8746
-----------------------------------------------------------
On June 28, 2012, 11:29 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5596/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 11:29 p.m.)
>
>
> Review request for rave and Raminder Singh.
>
>
> Description
> -------
>
> To begin with for RAVE-690, Added friend gadget and made changes in DB to populate friend
>
>
> This addresses bug RAVE-690.
> https://issues.apache.org/jira/browse/RAVE-690
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friends.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5596/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Friend Gadget
Posted by Raminder Singh <ra...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5596/#review8746
-----------------------------------------------------------
Ship it!
Ship It!
- Raminder Singh
On June 28, 2012, 11:29 p.m., Viknes B wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5596/
> -----------------------------------------------------------
>
> (Updated June 28, 2012, 11:29 p.m.)
>
>
> Review request for rave and Raminder Singh.
>
>
> Description
> -------
>
> To begin with for RAVE-690, Added friend gadget and made changes in DB to populate friend
>
>
> This addresses bug RAVE-690.
> https://issues.apache.org/jira/browse/RAVE-690
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friends.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/5596/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Viknes B
>
>
Re: Review Request: Friend Gadget
Posted by Viknes B <vi...@msn.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5596/
-----------------------------------------------------------
(Updated June 28, 2012, 11:29 p.m.)
Review request for rave and Raminder Singh.
Changes
-------
Removed the DB script changes and uploaded the new patch
Description
-------
To begin with for RAVE-690, Added friend gadget and made changes in DB to populate friend
This addresses bug RAVE-690.
https://issues.apache.org/jira/browse/RAVE-690
Diffs (updated)
-----
https://svn.apache.org/repos/asf/rave/trunk/rave-demo-gadgets/src/main/webapp/friends.xml PRE-CREATION
Diff: https://reviews.apache.org/r/5596/diff/
Testing
-------
Thanks,
Viknes B