You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by sl...@apache.org on 2007/06/30 18:43:53 UTC

svn commit: r552172 - in /incubator/tuscany/java/sca/modules/binding-jms/src: main/java/org/apache/tuscany/sca/binding/jms/ test/java/org/apache/tuscany/sca/binding/jms/

Author: slaws
Date: Sat Jun 30 09:43:52 2007
New Revision: 552172

URL: http://svn.apache.org/viewvc?view=rev&rev=552172
Log:
Stop the JMS connection on the binding reference when the domain is shut down

Modified:
    incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingInvoker.java
    incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingReferenceBindingProvider.java
    incubator/tuscany/java/sca/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSTestCase.java

Modified: incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingInvoker.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingInvoker.java?view=diff&rev=552172&r1=552171&r2=552172
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingInvoker.java (original)
+++ incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingInvoker.java Sat Jun 30 09:43:52 2007
@@ -126,6 +126,10 @@
             throw new InvocationTargetException(e);
         }
     }
+    
+    public void stop() throws NamingException, JMSException{
+        jmsResourceFactory.closeConnection();
+    }
 
     protected Message sendRequest(Object[] payload, Session session, Destination replyToDest) throws JMSException {
 

Modified: incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingReferenceBindingProvider.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingReferenceBindingProvider.java?view=diff&rev=552172&r1=552171&r2=552172
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingReferenceBindingProvider.java (original)
+++ incubator/tuscany/java/sca/modules/binding-jms/src/main/java/org/apache/tuscany/sca/binding/jms/JMSBindingReferenceBindingProvider.java Sat Jun 30 09:43:52 2007
@@ -19,6 +19,7 @@
 
 package org.apache.tuscany.sca.binding.jms;
 
+import java.util.ArrayList;
 import java.util.List;
 
 import org.apache.tuscany.sca.assembly.ComponentService;
@@ -41,6 +42,7 @@
     private RuntimeComponent          component;
     private RuntimeComponentReference reference;
     private JMSBinding                jmsBinding;
+    private List<JMSBindingInvoker>   jmsBindingInvokers = new ArrayList<JMSBindingInvoker>();
 
     public JMSBindingReferenceBindingProvider(RuntimeComponent component,
                                               RuntimeComponentReference reference,
@@ -99,8 +101,10 @@
         if (isCallback) {
             throw new UnsupportedOperationException();
         } else {
-            return new JMSBindingInvoker(jmsBinding,
-                                         operation);                                      
+            JMSBindingInvoker invoker =  new JMSBindingInvoker(jmsBinding,
+                                                               operation); 
+            jmsBindingInvokers.add(invoker);
+            return invoker;
         }
     }
 
@@ -113,6 +117,14 @@
     }
 
     public void stop() {
+        try {
+            for (JMSBindingInvoker invoker : jmsBindingInvokers) {
+                invoker.stop();
+                
+            }
+        } catch (Exception e) {
+            throw new JMSBindingException("Error stopping JMSReferenceBinding", e);
+        }        
     }
 
 }

Modified: incubator/tuscany/java/sca/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSTestCase.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSTestCase.java?view=diff&rev=552172&r1=552171&r2=552172
==============================================================================
--- incubator/tuscany/java/sca/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSTestCase.java (original)
+++ incubator/tuscany/java/sca/modules/binding-jms/src/test/java/org/apache/tuscany/sca/binding/jms/JMSTestCase.java Sat Jun 30 09:43:52 2007
@@ -76,7 +76,7 @@
         //broker.waitUntilStopped();
     }
     
-/* At the moment I can't get at the target list in order to aut generate queue names
+/* At the moment I can't get at the target list in order to auto generate queue names
  * so binding.jms with no configuration doesn't work
     @Test
     public void testHelloWorldMinimal() throws Exception {



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org