You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/25 10:05:07 UTC
[GitHub] [flink] danny0405 opened a new pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
danny0405 opened a new pull request #12319:
URL: https://github.com/apache/flink/pull/12319
Add documentation for dynamic table options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12319:
URL: https://github.com/apache/flink/pull/12319
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
}, {
"hash" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2890",
"triggerID" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74d888830b796a54187b8ca530b6ad8054a8cdb4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786)
* a57e64fff937b00b4c208c9f24abbf779177c448 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2890)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74d888830b796a54187b8ca530b6ad8054a8cdb4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12319:
URL: https://github.com/apache/flink/pull/12319#discussion_r435129153
##########
File path: docs/dev/table/sql/hints.md
##########
@@ -0,0 +1,73 @@
+---
+title: "SQL Hints"
+nav-parent_id: sql
+nav-pos: 6
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+* This will be replaced by the TOC
+{:toc}
+
Review comment:
Add one line to explain Table hints. This is a doc for hints, not only for `Dynamic Table Options`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136)
* 74d888830b796a54187b8ca530b6ad8054a8cdb4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
}, {
"hash" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2890",
"triggerID" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a57e64fff937b00b4c208c9f24abbf779177c448 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2890)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136)
* 74d888830b796a54187b8ca530b6ad8054a8cdb4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12319:
URL: https://github.com/apache/flink/pull/12319#discussion_r435129153
##########
File path: docs/dev/table/sql/hints.md
##########
@@ -0,0 +1,73 @@
+---
+title: "SQL Hints"
+nav-parent_id: sql
+nav-pos: 6
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+* This will be replaced by the TOC
+{:toc}
+
Review comment:
Add one line to explain Table hints.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633497723
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 (Mon May 25 10:15:35 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12319: [FLINK-17406][doc] Add documentation about dynamic table options
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12319:
URL: https://github.com/apache/flink/pull/12319#issuecomment-633504575
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2136",
"triggerID" : "222a7357e97b48ee7b7e3056c75ab60dc6d8d3e8",
"triggerType" : "PUSH"
}, {
"hash" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786",
"triggerID" : "74d888830b796a54187b8ca530b6ad8054a8cdb4",
"triggerType" : "PUSH"
}, {
"hash" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a57e64fff937b00b4c208c9f24abbf779177c448",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 74d888830b796a54187b8ca530b6ad8054a8cdb4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2786)
* a57e64fff937b00b4c208c9f24abbf779177c448 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org