You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/07/11 18:59:31 UTC
[jira] Created: (HARMONY-840) [classlib][beans] enabling of tests
from StatementTest class (3)
[classlib][beans] enabling of tests from StatementTest class (3)
-----------------------------------------------------------------
Key: HARMONY-840
URL: http://issues.apache.org/jira/browse/HARMONY-840
Project: Harmony
Type: Improvement
Environment: winXP
Reporter: Alexei Zakharov
Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
testExecute_ArrayGet
testExecute_ArrayInvalidSet
What have been done:
1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does.
2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-840) [classlib][beans] enabling of tests
from StatementTest class (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-840?page=all ]
Alexei Zakharov updated HARMONY-840:
------------------------------------
Attachment: StatementTest3.patch
> [classlib][beans] enabling of tests from StatementTest class (3)
> ----------------------------------------------------------------
>
> Key: HARMONY-840
> URL: http://issues.apache.org/jira/browse/HARMONY-840
> Project: Harmony
> Type: Improvement
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: StatementTest3.patch
>
> Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
> testExecute_ArrayGet
> testExecute_ArrayInvalidSet
> What have been done:
> 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does.
> 2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-840) [classlib][beans] enabling of tests
from StatementTest class (3)
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-840?page=comments#action_12420612 ]
Alexei Zakharov commented on HARMONY-840:
-----------------------------------------
Yes, everything works. Thanks!
> [classlib][beans] enabling of tests from StatementTest class (3)
> ----------------------------------------------------------------
>
> Key: HARMONY-840
> URL: http://issues.apache.org/jira/browse/HARMONY-840
> Project: Harmony
> Type: Improvement
> Environment: winXP
> Reporter: Alexei Zakharov
> Assignee: Mikhail Loenko
> Attachments: StatementTest3.patch
>
> Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
> testExecute_ArrayGet
> testExecute_ArrayInvalidSet
> What have been done:
> 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does.
> 2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-840) [classlib][beans] enabling of tests
from StatementTest class (3)
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-840?page=all ]
Mikhail Loenko resolved HARMONY-840:
------------------------------------
Resolution: Fixed
fixed in revision 421166
Alexei, please check that it was applied as expected
> [classlib][beans] enabling of tests from StatementTest class (3)
> ----------------------------------------------------------------
>
> Key: HARMONY-840
> URL: http://issues.apache.org/jira/browse/HARMONY-840
> Project: Harmony
> Type: Improvement
> Environment: winXP
> Reporter: Alexei Zakharov
> Assignee: Mikhail Loenko
> Attachments: StatementTest3.patch
>
> Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
> testExecute_ArrayGet
> testExecute_ArrayInvalidSet
> What have been done:
> 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does.
> 2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-840) [classlib][beans] enabling of tests
from StatementTest class (3)
Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-840?page=all ]
Mikhail Loenko reassigned HARMONY-840:
--------------------------------------
Assign To: Mikhail Loenko
> [classlib][beans] enabling of tests from StatementTest class (3)
> ----------------------------------------------------------------
>
> Key: HARMONY-840
> URL: http://issues.apache.org/jira/browse/HARMONY-840
> Project: Harmony
> Type: Improvement
> Environment: winXP
> Reporter: Alexei Zakharov
> Assignee: Mikhail Loenko
> Attachments: StatementTest3.patch
>
> Attached patch enables two more tests from org.apache.harmony.beans.tests.java.beans.StatementTest:
> testExecute_ArrayGet
> testExecute_ArrayInvalidSet
> What have been done:
> 1. I have reworked the exception throwing model of Statement.findArrayMethod(). Now our implementation throws the same set of exceptions as RI does.
> 2. I have also removed superfluous parameters from "get" and "set" invocations from tests since tests in their old form were invalid. However, old variants of tests pass on RI. IMHO it is RI bug. I have started new mail thread in the list about this topic. Anyway, even if we decide to be 100% compatible with RI here we will probably need do define an extra test. We don't need to test this doubtful logic in these tests IMHO.
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira