You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by maskit <gi...@git.apache.org> on 2016/05/21 08:58:36 UTC
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
GitHub user maskit opened a pull request:
https://github.com/apache/trafficserver/pull/654
TS-4466: Add links to other versions of the documentation
https://issues.apache.org/jira/browse/TS-4466
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maskit/trafficserver ts4466
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/654.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #654
----
commit 70a23a925be4800efbd24d82217e6d22084f2e14
Author: Masakazu Kitajo <ma...@apache.org>
Date: 2016-05-21T08:31:33Z
TS-4466: Add links to other versions of the documentation
commit 59fb3d33391bc4f9adc0417099ea96cddac88cba
Author: Masakazu Kitajo <ma...@apache.org>
Date: 2016-05-21T08:46:48Z
TS-4466: Specify language explicitly
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-221186963
Thank you for pointing out the issue. I found a fix for it on RTD's repository.
https://github.com/rtfd/readthedocs.org/commit/b15d50bc200677053c04f6ede6c72fd1055525dd
Also, I modified the template so that the switcher is collapsed until a reader clicks the current version at the bottom right.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
Posted by maskit <gi...@git.apache.org>.
Github user maskit commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-220767781
The template file could be considered as a derivative of this file. It's licensed under MIT.
https://github.com/snide/sphinx_rtd_theme/blob/master/sphinx_rtd_theme/versions.html
But I think the structure of tags and class names are sort of APIs to use this area.
Should I put original copyright and license to our LICENSE file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
Posted by jsime <gi...@git.apache.org>.
Github user jsime closed the pull request at:
https://github.com/apache/trafficserver/pull/654
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-220785838
Great! I've asked Jon to take a look at this as well, since he's our Docs guru :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...
Posted by jsime <gi...@git.apache.org>.
Github user jsime commented on the pull request:
https://github.com/apache/trafficserver/pull/654#issuecomment-221055926
This looks really good, except for one issue I've noticed. If you happen to be on a page which is nested pretty far down into the ToC (e.g. any of the experimental plugin docs in the Admin guide), and the chapter navigation in the left sidebar is pretty long, the language/version switcher can obscure the last couple entries in the expanded ToC list. Collapsing the new switcher with the arrow link just to the right of the currently selected version helps, but can still block the last entry in the ToC list (plus it may not be obvious for newcomers to the docs that there are any list items obscured at all).
Hopefully this image comes through clearly enough:
The screenshots left and center show left-hand ToC navigation entries being obscured by both the expanded and collapsed language/version switcher - the right hand shot shows the collapsed switcher with a shorter ToC list in which nothing is covered up.
My CSS chops aren't good enough to know right away how to correct that, but I'll see if I can come up with something. I can reproduce this issue in both Firefox and Chrome, fwiw.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---