You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/05/21 14:33:28 UTC

Review Request 70689: Improved log messages for SSL configuration.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70689/
-----------------------------------------------------------

Review request for mesos and Jan-Philip Gehrcke.


Repository: mesos


Description
-------

Improved log messages for SSL configuration.


Diffs
-----

  3rdparty/libprocess/src/openssl.cpp 789bef61b4bb38fa83ab2a016fd780ec97a8e6b7 


Diff: https://reviews.apache.org/r/70689/diff/1/


Testing
-------

No.


Thanks,

Benno Evers


Re: Review Request 70689: Improved log messages for SSL configuration.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70689/#review215412
-----------------------------------------------------------



Bad review!

Reviews applied: [70689]

Error:
2019-05-21 16:42:34 URL:https://reviews.apache.org/r/70689/diff/raw/ [1223/1223] -> "70689.patch" [1]
error: patch failed: 3rdparty/libprocess/src/openssl.cpp:515
error: 3rdparty/libprocess/src/openssl.cpp: patch does not apply

- Mesos Reviewbot


On May 21, 2019, 2:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70689/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 2:33 p.m.)
> 
> 
> Review request for mesos and Jan-Philip Gehrcke.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved log messages for SSL configuration.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp 789bef61b4bb38fa83ab2a016fd780ec97a8e6b7 
> 
> 
> Diff: https://reviews.apache.org/r/70689/diff/1/
> 
> 
> Testing
> -------
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 70689: Improved log messages for SSL configuration.

Posted by Jan-Philip Gehrcke via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70689/#review215410
-----------------------------------------------------------


Ship it!




Ship It!

- Jan-Philip Gehrcke


On May 21, 2019, 2:33 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70689/
> -----------------------------------------------------------
> 
> (Updated May 21, 2019, 2:33 p.m.)
> 
> 
> Review request for mesos and Jan-Philip Gehrcke.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved log messages for SSL configuration.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/openssl.cpp 789bef61b4bb38fa83ab2a016fd780ec97a8e6b7 
> 
> 
> Diff: https://reviews.apache.org/r/70689/diff/1/
> 
> 
> Testing
> -------
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>